-
Notifications
You must be signed in to change notification settings - Fork 43
Updates after upstream drop of legacy LArG4 #904
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
PetrilloAtWork
wants to merge
6
commits into
SBNSoftware:migrate/SBN2025A
Choose a base branch
from
PetrilloAtWork:feature/gp_dropLegacyG4FCL
base: migrate/SBN2025A
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
00c7063
Factorization of LArG4 settings from the LArG4 job configuration
PetrilloAtWork 74899fa
One fix to photonlibrary_builder_icarus.fcl (still not working)
PetrilloAtWork d0d0649
"Archived" several dirt and in-time generation configurations.
PetrilloAtWork 879e8a5
Archived configuration using legacy LArG4
PetrilloAtWork aeabd6b
Tentative update of job configurations depending on legacy LArG4
PetrilloAtWork f552947
Removed unnecessary inclusion of LArG4 configuration from some job co…
PetrilloAtWork File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
1 change: 0 additions & 1 deletion
1
...en/standard_g4_icarus_21apr21_laronly.fcl → ...G4/standard_g4_icarus_21apr21_laronly.fcl
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,146 @@ | ||
| # File: icarus_larg4_defs.fcl | ||
| # Purpose: definitions for standard LArG4 jobs | ||
| # | ||
| # This collection of presets can be used as building blocks for a full LArG4 | ||
| # job configuration. Essential parts are: | ||
| # | ||
| # services: { | ||
| # @table::icarus_larg4_services | ||
| # | ||
| # # ... additional services as needed | ||
| # } | ||
| # | ||
| # physics.producers: { | ||
| # @table::icarus_larg4_standard_producers | ||
| # | ||
| # # ... additional services as needed | ||
| # } | ||
| # | ||
| # physics.simulate: [ | ||
| # @sequence::icarus_larg4_standard_path | ||
| # # , additional labels as needed | ||
| # ] | ||
| # | ||
| # Note that `icarus_larg4_services` only provides service specific to LArG4; | ||
| # for a full, and possibly overfull, set of services, use `icarus_all_larg4_services`. | ||
| # | ||
| # A complete example can be found in `larg4_icarus.fcl`. | ||
| # | ||
|
|
||
| #include "services_icarus_simulation.fcl" | ||
| #include "larg4_services_icarus.fcl" | ||
|
|
||
| #include "LArG4.fcl" | ||
| #include "ionandscint_icarus.fcl" | ||
| #include "PDFastSim_icarus.fcl" | ||
| #include "simdrift_icarus.fcl" | ||
| #include "g4inforeducer.fcl" | ||
| #include "icarus_genericCRT.fcl" | ||
| #include "simplemerge_icarus.fcl" | ||
|
|
||
| BEGIN_PROLOG | ||
|
|
||
|
|
||
| # ------------------------------------------------------------------------------ | ||
| # --- ICARUS "standard" configuration | ||
| # --- | ||
| # | ||
| # (note overrides at the bottom) | ||
| # | ||
| # The service sets include: | ||
| # - `icarus_larg4_services`: only the services needed only by LArG4 | ||
| # - `icarus_all_larg4_services`: all services needed for a job including LArG4 | ||
| # | ||
| # Note that currently `icarus_g4_services` is directly taken from `larg4_services_icarus.fcl`. | ||
| # | ||
|
|
||
| # --- | ||
| # --- services | ||
| # --- | ||
| icarus_g4_services: { | ||
|
|
||
| @table::icarus_g4_services # from `larg4_services_icarus.fcl` (FHiCL will not recourse) | ||
|
|
||
| # icarus_g4_services.ParticleListAction.KeepDroppedParticlesInVolumes: ["volDetEnclosure"] | ||
| } | ||
|
|
||
| icarus_all_larg4_services: { | ||
| @table::icarus_g4_services | ||
| @table::icarus_larg4_services | ||
| } | ||
|
|
||
| # avoid huge log files | ||
| icarus_all_larg4_services.message.destinations.LogErrorFile.categories.SimDriftElectrons: { limit: 0 } | ||
| icarus_all_larg4_services.message.destinations.LogStandardOut.categories.SimDriftElectrons: { limit: 0 } | ||
|
|
||
| # Setup hack for 2D | ||
| icarus_all_larg4_services.SpaceChargeService.is2DdriftSimHack: true | ||
|
|
||
|
|
||
| # --- | ||
| # --- modules | ||
| # --- | ||
| icarus_larg4_standard_producers: { | ||
|
|
||
| # A dummy module that forces the G4 physics list to be loaded | ||
| loader: { module_type: "PhysListLoader" } | ||
|
|
||
| # The geant4 step | ||
| largeant: { | ||
|
|
||
| @table::standard_larg4 # from `LArG4.fcl` (in LArSoft/larg4) | ||
|
|
||
| # Store MCParticleLite in G4 to store dropped particles from KeepEMShowerDaughters: false | ||
| StoreDroppedMCParticles: false | ||
|
|
||
| } | ||
|
|
||
| # Creation of ionization electrons and scintillation photons (keep ionization name for compatibility) | ||
| ionization: @local::icarus_ionandscint | ||
|
|
||
| # Light propogation | ||
| pdfastsim: @local::icarus_pdfastsim_pvs | ||
|
|
||
| # Electron propogation | ||
| simdrift: @local::icarus_simdrift | ||
|
|
||
| # needs to run right after largeant | ||
| sedlite: { | ||
| @table::sbn_largeant_info_reducer # from `g4inforeducer.fcl` (in LArSoft/larg4!!) | ||
|
|
||
| SimEnergyDepositLabel: "largeant:LArG4DetectorServicevolTPCActive" | ||
| useOrigTrackID: true # needed since origTrackID not filled for sedlite in SBND | ||
|
|
||
| } | ||
|
|
||
| # Generic CRT | ||
| genericcrt: @local::icarus_genericCRT | ||
|
|
||
| # simplemerge for ML | ||
| simplemerge: @local::simplemerge | ||
|
|
||
| } | ||
|
|
||
| # Store MCParticleLite in G4 to store dropped particles from KeepEMShowerDaughters: false | ||
| icarus_larg4_standard_producers.largeant.StoreDroppedMCParticles: false | ||
|
|
||
|
|
||
| # --- | ||
| # --- paths | ||
| # --- | ||
| icarus_larg4_standard_path: [ | ||
| loader | ||
| , largeant | ||
| , ionization | ||
| , pdfastsim | ||
| , simdrift | ||
| , sedlite | ||
| , genericcrt | ||
| , simplemerge | ||
| ] | ||
|
|
||
|
|
||
| # ------------------------------------------------------------------------------ | ||
|
|
||
| END_PROLOG | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.