Conversation
Test Results1 110 tests 1 110 ✅ 48s ⏱️ Results for commit 87f5cbc. ♻️ This comment has been updated with latest results. |
…ce, log_extra_fields, exec_selinux_context, exec_smack_process_label, unset_environ (Resolves #465) Each grammar is calibrated against the systemd C parser, biased toward false-negatives over false-positives (documented per-validator in KDoc): - config_parse_set_credential (ltypes 0,1): <id>:<data>; id is credential_name_valid (no '/' ':' control, not "."/".."), data arbitrary. - config_parse_load_credential (ltypes 0,1): <id>[:<source>]; id is credential_name_valid, source loosely constrained. - config_parse_log_namespace: log_namespace_name_valid (filename-safe, no '/', not "."/".."). - config_parse_log_extra_fields: list of FIELD=value, FIELD a journal field name [A-Z][A-Z0-9_]{0,63}. - config_parse_exec_selinux_context / config_parse_exec_smack_process_label: optional leading '-' then a specifier-validated string. - config_parse_unset_environ: list of env names or NAME=value assignments. Because the credential parsers cover ltypes 0 and 1, this clears 9 burn-down entries: OptionValueTest 366 -> 357 missing functions (1979 -> 2024 found). Each validator ships valid + invalid tests; full suite passes. Stacked on #464 (both touch AiGenerated.kt); merge #464 first. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #465. Seven validators calibrated against the systemd C parsers, in
SimpleGrammarOptionValues, each with valid + invalid tests.Stacked on #464 (both edit
AiGenerated.kt) — base is set toissue-463; it auto-retargets to242.xonce #464 merges. Merge #464 first.config_parse_set_credentialid:data; id =credential_name_valid(no/:ctrl, not./..); data arbitraryconfig_parse_load_credentialid[:source]; id =credential_name_valid; source looseconfig_parse_log_namespacelog_namespace_name_valid(filename-safe, no/, not./..)config_parse_log_extra_fieldsFIELD=value, FIELD =[A-Z][A-Z0-9_]{0,63}config_parse_exec_selinux_context-+ specifier-validated stringconfig_parse_exec_smack_process_label-+ specifier-validated stringconfig_parse_unset_environNAME=valueImpact
OptionValueTest366 → 357 missing functions (1979 → 2024 found).🤖 Generated with Claude Code