fix: underline grammar-backed keys instead of recoloring them (#467)#481
Open
SJrX wants to merge 1 commit into
Open
fix: underline grammar-backed keys instead of recoloring them (#467)#481SJrX wants to merge 1 commit into
SJrX wants to merge 1 commit into
Conversation
The key marker (GrammarEngineKeyAnnotator) tinted grammar-backed keys with a distinct color; having two key colors was too distracting, especially on light themes. Switch it to a plain underline so the key keeps its normal color and the grammar marker is subtle. Refs #467 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The key marker from #474 (
GrammarEngineKeyAnnotator) tinted grammar-backed keys (Bond,Description, …) a distinct color. Having two different key colors was too distracting — especially on light themes. Switch it to a plain underline: the key keeps its normal color and just gets a subtle underline to signal "grammar-backed".Change
NEW_ENGINE_KEYnow defaults toTextAttributes(effectType = LINE_UNDERSCORE)(gray underline, no foreground change) instead ofDefaultLanguageHighlighterColors.METADATA. One-line behavioral change; the annotator still marks the same keys, just less loudly. Existing test (asserts the key gets the marker) still passes; full suite green.Refs #467
🤖 Generated with Claude Code