Skip to content

feat: single transaction for each backend operation (RDFA-355)#119

Open
rema-soptim wants to merge 8 commits into
mainfrom
fix/RDFA-355-single-transaction
Open

feat: single transaction for each backend operation (RDFA-355)#119
rema-soptim wants to merge 8 commits into
mainfrom
fix/RDFA-355-single-transaction

Conversation

@rema-soptim
Copy link
Copy Markdown
Collaborator

@rema-soptim rema-soptim commented May 18, 2026

Description

  • Transactions are now on graphwithContext Level
  • refactored all usages of transaction to now be a try with resource
  • Changelog is now stored inside the graphWithContext instead of separately
  • custom shacl is now also added to the vcs

Test Checklist

General Behavior

  • Components reload automatically when data changes
  • Editing features are disabled in readonly datasets
  • Dialogs pre-select current dataset/graph
  • Required fields are validated in dialogs
  • Discarding unsaved changes opens a discard cancel confirm dialog

Global MenuBar

  • Navigate to home page works
  • File menu:
    • Import → Graph/SHACL works
    • Export → Graph/SHACL works
    • Share Snapshot works
    • Delete → Dataset/Graph works
  • Edit menu:
    • New → Class works
    • New → Package works
    • Edit/View → Create/Edit/View Ontology works
    • Edit/View → Package works
    • Undo/Redo (Ctrl+Z / Ctrl+Y) works
    • Enable/Disable editing works
    • Manage/View namespaces works
    • Delete → Ontology/Package works
  • View menu:
    • Changelog opens and shows current graph
    • Compare Graphs opens
    • Full SHACL works
  • Help menu:
    • Help link works
    • Submit Feedback link works
    • About navigation works

Welcome Page

  • Navigation to Editor works
  • Tips are displayed
  • Security and data information displayed
  • Copyright and version information displayed

Editor - MenuBar

  • Search function works with all filters (All Datasets, Current Dataset, Current Graph, Current Package)
  • Search finds classes, attributes, associations, packages
  • "Enable Editing" button appears for readonly datasets

Editor - Navigation

  • Hierarchical display (Datasets → Graphs → Packages) works
  • Selection is highlighted
  • Selecting a class does not change dataset/graph/package selection
  • Class selection stays open/highlighted when switching dataset/graph/package
  • Datasets and graphs are collapsible
  • Single click selects; double click or chevron toggles expand/collapse
  • State persists on reload (non-browser)
  • Context menus act on the dataset/graph/package they were opened on
  • Hover labels show prefixes when configured
  • Dataset context menu:
    • Import graph works (disabled in readonly datasets)
    • Share Snapshot works
    • Enable/Disable editing works
    • Manage/View namespaces works
    • Delete dataset works
  • Graph context menu:
    • New package works (disabled in readonly datasets)
    • Undo/Redo works (only enabled when available)
    • Create Ontology
    • Edit Ontology (View Ontology in readonly)
    • Delete Ontology
    • Changelog navigation works
    • Compare dialog works
    • SHACL import/export/full view works (import disabled in readonly datasets)
    • Export graph works
    • Delete graph works (disabled in readonly datasets)
  • Package context menu:
    • Create new class works (disabled in readonly datasets)
    • View/Edit package works
    • Copy URL works
    • Delete package works (disabled for external/default packages and readonly datasets)
  • Class context menu:
    • Open class (editor) works
    • SHACL works
    • Delete class works (disabled in readonly datasets)

Editor - Package View

  • Class diagram displays correctly
  • Moving nodes works and layout changes persist after reload
  • Loading animation shows while loading
  • Info cards show when no package or no classes available
  • Drag and zoom diagram works
  • "Reset View" button works
  • "Filter View" works
  • "Reset Layout" button resets diagram to auto-generated layout
  • Click on class opens class editor

Editor - Class Editor

  • Display and edit class properties: Label, Namespace, Package, Derived from, Abstract, Stereotypes, Attributes, Associations, Comment
  • Delete class works
  • Save changes works
  • Discard changes works
  • Attribute Editor works
  • Association Editor works
  • attribute/association SHACL View works
  • Class SHACL View works

Prefixes Page

  • View, add, remove and edit namespaces works

Changelog Page

  • Select graph and display write operations works
  • Operations shown in reverse chronological order
  • Detailed view of changed triples works
  • Restoring graph to a version works

Compare Page

  • Compare two graphs works

github-code-quality[bot]
github-code-quality Bot found potential problems May 18, 2026
View reviewed changes
Comment thread backend/src/main/java/org/rdfarchitect/models/cim/rendering/RenderCIMCollectionUseCase.java Fixed
Comment thread backend/src/main/java/org/rdfarchitect/database/inmemory/GraphWithContextTransactional.java Fixed
Comment thread backend/src/main/java/org/rdfarchitect/database/inmemory/GraphWithContextTransactional.java Fixed
Comment thread backend/src/main/java/org/rdfarchitect/database/inmemory/GraphWithContextTransactional.java Fixed
github-code-quality[bot]
github-code-quality Bot found potential problems May 18, 2026
View reviewed changes
Comment thread backend/src/main/java/org/rdfarchitect/database/inmemory/GraphWithContextTransactional.java Fixed
@rema-soptim rema-soptim force-pushed the fix/RDFA-355-single-transaction branch 4 times, most recently from 4049065 to 68ca978 Compare May 21, 2026 11:20
@rema-soptim rema-soptim marked this pull request as ready for review May 21, 2026 11:22
@spah-soptim spah-soptim self-requested a review May 26, 2026 09:53
@rema-soptim rema-soptim force-pushed the fix/RDFA-355-single-transaction branch from 68ca978 to 6285b13 Compare May 27, 2026 07:45
spah-soptim
spah-soptim previously requested changes May 28, 2026
View reviewed changes
Comment thread backend/src/main/java/org/rdfarchitect/database/inmemory/GraphWithContextTransactional.java Outdated
Comment on lines +95 to +98
this.usedRewindables =
List.of(
new NamedRewindable("rdf", rdfGraph),
new NamedRewindable("shacl", customSHACL));
Copy link
Copy Markdown
Member

@spah-soptim spah-soptim May 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DiagramLayoutDelta not used in usedRewindables. So undo, redo, restoreToVersion never call diagramLayout.undo()/redo(). Leaving stale layout data for deleted classes, and after the class reappears still has its old layout entry.

Copy link
Copy Markdown
Collaborator Author

@rema-soptim rema-soptim Jun 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the current behaviour, since we have not discussed a proper "new" behaviour i suggest, we should keep this for now.

Comment thread backend/src/main/java/org/rdfarchitect/services/update/classes/UpdateClassService.java
Comment thread .../main/java/org/rdfarchitect/services/dl/update/packagelayout/UpdatePackageLayoutService.java Outdated
Comment thread backend/src/main/java/org/rdfarchitect/database/inmemory/GraphWithContextTransactional.java Outdated
Comment thread backend/src/main/java/org/rdfarchitect/database/inmemory/GraphWithContextCollection.java Outdated
Comment thread .../src/main/java/org/rdfarchitect/services/dl/update/classlayout/UpdateClassLayoutService.java Outdated
Comment thread .../src/main/java/org/rdfarchitect/services/dl/update/classlayout/UpdateClassLayoutService.java Outdated
Comment thread backend/src/main/java/org/rdfarchitect/services/shacl/SHACLStoringService.java Outdated
github-code-quality[bot]
github-code-quality Bot found potential problems May 28, 2026
View reviewed changes
Comment thread backend/src/main/java/org/rdfarchitect/database/inmemory/diagrams/CustomDiagram.java Fixed
@rema-soptim rema-soptim force-pushed the fix/RDFA-355-single-transaction branch 2 times, most recently from 0385eec to fb24ae1 Compare June 1, 2026 16:05
@spah-soptim spah-soptim dismissed their stale review June 2, 2026 14:05

LGTM.
Reviewed but not fully tested.

spah-soptim
spah-soptim requested changes Jun 2, 2026
View reviewed changes
Comment thread backend/src/main/java/org/rdfarchitect/models/changelog/ChangeLog.java Outdated
Comment on lines +213 to +221
public void replaceOldest(ChangeLogEntry entry) {
checkWriteTransaction();
pendingMutations.add(
() -> {
undoStack.removeLast();
undoStack.addLast(entry);
redoStack.clear();
});
}
Copy link
Copy Markdown
Member

@spah-soptim spah-soptim Jun 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RDFGraphDelta caps the version history (default 256), but ChangeLog's undo/redo stacks are never trimmed.
The method for it (ChangeLog.replaceOldest(...)) is only called from tests, never in the code. So canUndo() keeps reporting true after the graph has already dropped the underlying deltas.

Copy link
Copy Markdown
Collaborator Author

@rema-soptim rema-soptim Jun 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed method, its intended, that the version history is not trimmed even though changes cannot be resorted anymore.

@rema-soptim rema-soptim force-pushed the fix/RDFA-355-single-transaction branch from 7bc16fa to de45f86 Compare June 3, 2026 07:30
@rema-soptim
feat(RDFA-355): single transaction, changelog improvements, undo/redo…
d127639 
… refactoring

- introduced GraphContext and VersionControl interfaces
- moved undo/redo/restore from DatabasePort into VersionControl (part of GraphContext)
- improved changelog messages and fixed transaction bugs
- replaced string UUIDs with actual UUID class
- added DL initialization for fetch-from-database graphs
- fixed bug where exporting was not possible
- fixed bug where associations couldn't be restored in changelog
Fix property shapes for DanglingReferences  and IdentofiedObject to use correct path and targetSubjectsOf instead of sh:targetNode
@rema-soptim
Update of the ReadMe
44bad68
@rema-soptim
Rebase fixes
a71cc2d
@rema-soptim
added transaction usage for custom diagrams
ae321e6
@rema-soptim
fixed more rebase issues
ce72682
@rema-soptim
frontend format
f3339be
@rema-soptim
fixed unit test
07577f2
@rema-soptim
rebase fix
18ed6d3
@rema-soptim rema-soptim force-pushed the fix/RDFA-355-single-transaction branch from 045a351 to 18ed6d3 Compare June 3, 2026 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@spah-soptim spah-soptim spah-soptim requested changes

+1 more reviewer

@github-code-quality github-code-quality[bot] github-code-quality[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rema-soptim @spah-soptim