Skip to content

bugfix blocking on repeated song request enqueue during shutdown#132

Open
nickwitten wants to merge 1 commit into
mainfrom
dev/nick/shutdown-song-bugfix
Open

bugfix blocking on repeated song request enqueue during shutdown#132
nickwitten wants to merge 1 commit into
mainfrom
dev/nick/shutdown-song-bugfix

Conversation

@nickwitten
Copy link
Copy Markdown
Contributor

Song request enqueue was blocking main loop for power board as the shutdown song was repeatedly enqueued and only dequeued after each song was completed.

Removed redundant request in the coms task.

Changed spam song request enqueue to periodic enqueue.

@nickwitten nickwitten requested a review from guyfleeman April 19, 2026 15:47
@guyfleeman
Copy link
Copy Markdown
Contributor

guyfleeman commented Apr 19, 2026

could just remove _audio_publisher unless there's a strong future need for it. Fix seems reasonable tho. I think in general a publish().await is almost always wrong unless its related to a param update maybe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants