zero init radio bridge packets#397
Merged
Merged
Conversation
chachmu
approved these changes
May 22, 2026
Contributor
|
My understanding is that ROS Jazzy already initializes the data in the message type even without using braces, but it doesn't hurt to be explicit about it. Are you actually seeing issues caused by this? |
Contributor
This PR is initializing the radio packet struct, which is not a ROS message type. |
barulicm
approved these changes
May 22, 2026
Contributor
|
🤦 I keep forgetting the radio bridge internal types aren't ROS messages |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Zero initialize radio packets so that garbage isn't sent in fields that aren't explicitly set.