Skip to content

Cleanup of some of the changes#745

Merged
7w1 merged 2 commits into
SableClient:devfrom
nushea:small-fixes
May 5, 2026
Merged

Cleanup of some of the changes#745
7w1 merged 2 commits into
SableClient:devfrom
nushea:small-fixes

Conversation

@nushea
Copy link
Copy Markdown
Member

@nushea nushea commented May 5, 2026

Description

Fixes the issues with the sizing of the user-hero, small saving issue, previews now showing when put in the [](), and matrix.to links being added to link-previews even though they reasonably shouldn't. It also fixes the matrix.to links to be made with a trailing / to avoid weird tricks in the usage of them for malicious purposes

This is general maintenance however so does not really need a changeset because its just a bunch of extremely small changes

Fixes #740

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

AI disclosure:

  • Partially AI assisted (clarify which code was AI assisted and briefly explain what it does).
  • Fully AI generated (explain what all the generated code does in moderate detail).

I had a nightmare that the new version shipped incomplete code

@nushea nushea requested review from 7w1 and hazre as code owners May 5, 2026 12:13
Comment thread src/app/components/editor/output.ts Fixed
@nushea nushea force-pushed the small-fixes branch 2 times, most recently from d289efc to 1f123f6 Compare May 5, 2026 12:23
@nushea nushea added the internal label May 5, 2026
Comment thread src/app/components/message/MsgTypeRenderers.tsx Fixed
@7w1 7w1 mentioned this pull request May 5, 2026
9 tasks
@7w1 7w1 added this pull request to the merge queue May 5, 2026
@7w1 7w1 removed this pull request from the merge queue due to a manual request May 5, 2026
@7w1 7w1 added this pull request to the merge queue May 5, 2026
Merged via the queue into SableClient:dev with commit 71460e4 May 5, 2026
12 checks passed
@nushea nushea deleted the small-fixes branch May 5, 2026 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Moderation controls offset

3 participants