Skip to content

Improve forward modal #808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
7w1 merged 3 commits into from
May 14, 2026
Merged

Improve forward modal #808

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b2adebd
feat: forward modal swap & forward to same room
7w1 May 14, 2026
7bca285
fix: close modal instantly
7w1 May 14, 2026
d439147
changeset
7w1 May 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/fix-modal-layout-thing.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
default: minor
---

Upgraded the forward modal to use the same modal present for search and added the ability to forward to same room the message is from.
14 changes: 6 additions & 8 deletions src/app/components/message/modals/GlobalModalManager.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,14 @@ import { MessageReadReceiptInternal } from './MessageReadRecipts';
export function GlobalModalManager() {
const [modal, setModal] = useAtom(modalAtom);

if (!modal) return null;

const close = () => setModal(null);

if (modal?.type === ModalType.Forward) {
return <MessageForwardInternal room={modal.room} mEvent={modal.mEvent} onClose={close} />;
}

if (!modal) return null;

return (
<Overlay open backdrop={<OverlayBackdrop />}>
<OverlayCenter>
Expand All @@ -42,12 +46,6 @@ export function GlobalModalManager() {
</Box>
)}

{modal.type === ModalType.Forward && (
<Box>
<MessageForwardInternal room={modal.room} mEvent={modal.mEvent} onClose={close} />
</Box>
)}

{modal.type === ModalType.Source && (
<Modal variant="Surface" size="300">
<MessageSourceInternal room={modal.room} mEvent={modal.mEvent} onClose={close} />
Expand Down
Loading
Loading