feat(timeline): configurable message grouping threshold#819
Open
Just-Insane wants to merge 4 commits into
Open
feat(timeline): configurable message grouping threshold#819Just-Insane wants to merge 4 commits into
Just-Insane wants to merge 4 commits into
Conversation
Add Discord-style message grouping where consecutive messages from the same sender within a configurable time window collapse the sender header. - Add messageGroupingThreshold to Settings type (default: 2 min) - Replace hardcoded 2-min threshold in useProcessedTimeline with the setting - Wire useSetting in RoomTimeline and pass to useProcessedTimeline - Add MessageGrouping component in Experimental settings with 5 options: 2 min (default), 5 min, 15 min (Discord-style), 30 min, 60 min Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Just-Insane
force-pushed
the
feat/message-grouping
branch
from
2f48d48 to
44ef75c
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR makes the timeline’s “consecutive message grouping” time window configurable via a new user setting, replacing the previously hardcoded 2-minute threshold.
Changes:
- Adds a new
messageGroupingThresholdsetting (default2) to persisted settings. - Threads the threshold through
RoomTimelineintouseProcessedTimeline, and uses it in the “same group” collapse decision. - Adds an Experimental settings UI entry to adjust the threshold, plus a small refactor in
RoomTimelineto avoidtoReversed().find(...).
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/app/state/settings.ts | Adds the new persisted setting and its default. |
| src/app/hooks/timeline/useProcessedTimeline.ts | Introduces an option for the grouping threshold and applies it in collapse logic. |
| src/app/features/settings/experimental/MessageGrouping.tsx | New settings UI control for selecting a grouping threshold. |
| src/app/features/settings/experimental/Experimental.tsx | Wires the new Message Grouping tile into the Experimental settings page. |
| src/app/features/room/RoomTimeline.tsx | Reads the setting, passes it into timeline processing, and refactors “edit last message” lookup. |
| .changeset/message-grouping.md | Adds a release note entry for the new feature. |
Comments suppressed due to low confidence (1)
src/app/state/settings.ts:310
- This setting is used in a time comparison, but it currently relies on the generic “finite number” sanitizer, which allows negative values and non-integers. That can lead to surprising behavior (e.g., negative values effectively disable grouping) and values that the UI
<select>can’t represent. Consider adding a dedicated sanitizer/migration formessageGroupingThreshold(e.g., integer minutes, minimum 0, and optionally an upper bound).
// experimental
messageGroupingThreshold: 2,
// furry stuff
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+8
to
+14
| const THRESHOLD_OPTIONS: { value: number; label: string }[] = [ | ||
| { value: 2, label: '2 min (default)' }, | ||
| { value: 5, label: '5 min' }, | ||
| { value: 15, label: '15 min (Discord-style)' }, | ||
| { value: 30, label: '30 min' }, | ||
| { value: 60, label: '60 min' }, | ||
| ]; |
Comment on lines
+31
to
+34
| * full user header. Defaults to 2 (the original behaviour). Set higher | ||
| * (e.g. 15) for Discord-style compact grouping. | ||
| */ | ||
| messageGroupingThreshold?: number; |
Comment on lines
+173
to
+175
| // experimental | ||
| messageGroupingThreshold: number; | ||
|
|
- Add 'Off (no grouping)' option (value 0) to threshold select so users can disable grouping; unknown/custom values now have a valid fallback - Make messageGroupingThreshold required in UseProcessedTimelineOptions to force all callers to explicitly pass the user setting - Plumb messageGroupingThreshold through ThreadDrawer.tsx so thread timelines respect the same grouping setting as the main timeline
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Exposes the message grouping time threshold as a user-configurable setting. Messages sent within the threshold window by the same sender are visually grouped (compact, no repeated avatar/name). Users can now adjust this window to taste or disable grouping entirely.
Fixes #
Type of change
Checklist:
AI disclosure:
A
messageGroupingThresholdMssetting key was added to the settings schema with a default matching the previous hardcoded value. The appearance settings panel gained a number input bound to that key. The timeline renderer reads the setting instead of the constant and uses it in the same-group comparison that decides whether to render a compact or full message row. Setting the value to 0 effectively disables grouping.