fix(emoji-board): skip displayCheck on FocusTrap activation#820
Open
Just-Insane wants to merge 2 commits into
Open
fix(emoji-board): skip displayCheck on FocusTrap activation#820Just-Insane wants to merge 2 commits into
Just-Insane wants to merge 2 commits into
Conversation
FocusTrap's default displayCheck:'full' calls getComputedStyle() on every tabbable element when the board opens. With hundreds of emoji buttons in the visible groups this causes a multi-hundred ms freeze. Using displayCheck:'none' skips that DOM traversal entirely while preserving all keyboard-navigation and focus-trap behaviour.
Just-Insane
force-pushed
the
fix/emoji-board-focustrap
branch
from
c95ed49 to
e09459c
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses a focus-trap activation error in the emoji board by disabling tabbable’s default displayCheck, which can traverse the DOM and throw during early mount/layout when elements have zero dimensions.
Changes:
- Pass
tabbableOptions: { displayCheck: 'none' }to the emoji board’sFocusTrapconfiguration to avoid DOM visibility checks on activation. - Add a
.changesetentry documenting the patch-level user-facing fix.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/app/components/emoji-board/EmojiBoard.tsx | Updates focusTrapOptions to skip tabbable’s display checking during activation. |
| .changeset/emoji-board-focustrap.md | Adds a patch changeset documenting the focus trap reliability fix. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
focus-trap(used by the emoji board) runs adisplayCheckby default on activation, which traverses the DOM to find tabbable elements. This can throw when elements have zero dimensions (e.g. immediately after mount before layout). PassingdisplayCheck: 'none'skips that check and lets the trap activate reliably.Fixes #
Type of change
Checklist:
AI disclosure:
The change passes a single option object to the
focus-trapactivate()call. Skipping the display check prevents the library from traversing the DOM for tabbable elements before the emoji board has finished layout, which was causing an activation error immediately after mount.