fix(navigation): route DM rooms to /direct before checking space parents#878
Open
Just-Insane wants to merge 2 commits into
Open
fix(navigation): route DM rooms to /direct before checking space parents#878Just-Insane wants to merge 2 commits into
Just-Insane wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes incorrect navigation where DM rooms that also belong to a space were being routed to a space URL instead of /direct/{roomId} by prioritizing DM routing before any space-parent resolution.
Changes:
- Move the DM detection branch (
mDirects.has(roomId)) to the top ofnavigateRoomto short-circuit to/direct. - Remove the now-redundant DM routing block later in the function.
- Add a patch changeset documenting the fix.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/app/hooks/useRoomNavigate.ts |
Prioritizes DM routing before space-parent navigation to prevent misrouting DMs into space URLs. |
.changeset/dm-routing.md |
Adds a patch changeset entry describing the DM routing fix. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+40
to
+44
| // DM rooms always navigate to /direct, regardless of space membership. | ||
| if (mDirects.has(roomId)) { | ||
| navigate(getDirectRoomPath(roomIdOrAlias, eventId), opts); | ||
| return; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
DM rooms with a space parent were being routed to the space URL instead of
/direct. The navigation logic now checks whether the room is a DM first and routes to/direct/{roomId}regardless of space membership.Fixes #
Type of change
Checklist:
AI disclosure:
The fix inserts an early
isDM(room)guard at the top of the navigation URL resolver so DM rooms short-circuit to/direct/{roomId}before the space-parent walk runs.