build(deps): bump docker/login-action from 3 to 4#44
Closed
dependabot[bot] wants to merge 33 commits into
Closed
Conversation
…he (#37) Using Interlocked.Increment/Read instead of lock(_statsLock) removes unnecessary contention on the hot path. Cache hit/miss counters are simple atomic increments that don't need mutual exclusion with other state.
- Add <summary>, <param>, and <returns> tags to all 10 lifecycle methods - Document initialization order, dependency resolution, and shutdown semantics - Describe plugin activation/deactivation hooks and resource cleanup
Add XML doc comments to IPluginManagerService
…unload cleanup (closes #19)
… declarations (closes #18)
Comprehensive documentation covering: - How to declare plugin dependencies with version bounds and optionality - Resolving the transitive dependency closure at runtime - Detecting circular dependencies - Visualising dependency graphs - Caching behaviour and how to invalidate it - Configuration reference and troubleshooting tips closes #39
Comprehensive documentation covering: - Setting up and configuring the marketplace client - Searching the marketplace with filter/sort options - Installing plugins and verifying compatibility - The compatibility matrix and how status is determined - Step-by-step publishing workflow (metadata, archive, registry API) - Best practices for versioning, tagging, and changelogs - Troubleshooting common errors (404, 502, unknown compatibility, key rejection) closes #40
The IPluginLifecycle interface (OnBeforeLoadAsync, OnAfterLoadAsync, OnBeforeUnloadAsync, OnAfterUnloadAsync) and its invocation from PluginLoaderService were already in place. This commit adds a dedicated test suite that: - Confirms all four hook methods exist on the interface - Verifies all hooks return Task (so they can be awaited) - Validates that hooks fire in the correct order during load and unload - Confirms that CancellationToken is accepted by every hook - Documents that the interface is opt-in (plugins not implementing it skip hooks automatically, as the loader uses reflection to discover implementors) closes #41
- Make plugin metadata optional in PluginValidator (was requiring it for all plugins, breaking basic validation tests) - Add author validation when metadata is provided - Add maximum version < minimum version validation for dependencies - Update dependency error messages to include 'minimum version' - Fix DependencyResolutionService tests to mock GetAllLoadedPluginsAsync (implementation uses this, not GetLoadedPluginAsync) - Fix ClearDependencyCacheAsync test assertion to use NotBeSameAs - Fix Plugin.AddDependency dedup check to use DependencyPluginId instead of PluginId (bug prevented adding multiple dependencies) - Fix chained dependency test to expect transitive resolution (2 items)
- IMarketplaceBrowserService interface with GetCategoriesAsync, GetTrendingAsync, GetFeaturedAsync, BrowseCategoryAsync, GetHomePageAsync - MarketplaceBrowserService implementation with multi-level caching (categories 6h, trending 15m, featured 1h, home page 10m) - 8 built-in plugin categories (analytics, auth, caching, database, logging, messaging, security, ui) - Registered via AddPluginMarketplace() alongside existing marketplace service - CLI: marketplace --action search|info|install with --query, --id, --version, --target, --limit flags - 7 unit tests covering categories, trending, featured, browse, home page
- IHotSwapService interface: SwapPluginAsync, RollbackSwapAsync, GetLastSwapRecordAsync, GetSwapHistoryAsync, RegisterPostSwapCallback, CanSwap - HotSwapService implementation: unloads old ALC, loads new assembly in a fresh context, best-effort rollback on failure, per-plugin swap history capped at 50 entries, post-swap callbacks - SwapRecord immutable model with PreviousAssemblyPath, NewAssemblyPath, Duration, RolledBack flag - Registered as IHotSwapService singleton in AddPluginEngine() - CLI: swap --id <guid> --path <new-assembly-path> - 15 unit tests covering CanSwap states, success/failure paths, rollback, history, and callback lifecycle
- IPluginDependencyResolver interface: GetInstallOrderAsync, FindConflictsAsync, BuildResolutionPlanAsync - PluginDependencyResolver implementation using Kahn's topological sort for install ordering; pairwise min/max constraint intersection for conflict detection; transitive closure for resolution plans - DependencyConflict, ConflictingRequirement, DependencyResolutionPlan, ResolutionStep, ResolutionAction models - ResolutionPlan.IsExecutable = true only when zero conflicts detected - Registered as IPluginDependencyResolver singleton in AddPluginEngine() - CLI: resolve --id <guid> prints ordered steps and any conflicts - 9 unit tests covering linear chains, diamond graphs, circular deps, conflict detection, and full resolution plan generation
Bumps [docker/login-action](https://github.com/docker/login-action) from 3 to 4. - [Release notes](https://github.com/docker/login-action/releases) - [Commits](docker/login-action@v3...v4) --- updated-dependencies: - dependency-name: docker/login-action dependency-version: '4' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
added
dependencies
Author
|
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
dependabot
Bot
deleted the
dependabot/github_actions/docker/login-action-4
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps docker/login-action from 3 to 4.
Release notes
Sourced from docker/login-action's releases.
... (truncated)
Commits
650006cMerge pull request #960 from docker/dependabot/npm_and_yarn/aws-sdk-dependenc...99df1a3chore: update generated content3ab375fbuild(deps): bump the aws-sdk-dependencies group across 1 directory with 2 up...39d8580Merge pull request #970 from docker/dependabot/npm_and_yarn/docker/actions-to...4eefcd3chore: update generated content56d092cbuild(deps): bump@docker/actions-toolkitfrom 0.86.0 to 0.90.0e2e31caMerge pull request #976 from docker/dependabot/npm_and_yarn/actions/core-3.0.10bced94chore: update generated content3e75a0fbuild(deps): bump@actions/corefrom 3.0.0 to 3.0.1365bebdMerge pull request #984 from docker/dependabot/github_actions/aws-actions/con...Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)