Sasview database#106
Draft
summerhenson wants to merge 1148 commits into
Draft
Conversation
krzywon
reviewed
Feb 7, 2025
krzywon
left a comment
krzywon
left a comment
Collaborator
There was a problem hiding this comment.
In addition to my inline comments, a few general notes:
- I said this in the meeting, but wanted to reiterate it - good use of atomic commits with specific commit messages
- Some python formatting would be useful. Running everything through ruff could be worthwhile.
- Relative imports can be fragile, but mostly when trying to run a python file directly. That isn't easy with Django, so it's not that huge an issue, but wanted to mention it.
- Another thing we discussed at today's meeting, but wanted to mention again, is user auth and request.user clashes. Many of the checks don't ensure the authenticated user is the data owner.
Overall, a good start to the project. I'll try to make comments every week, or as updates are made.
summerhenson
force-pushed
the
sasview-database
branch
2 times, most recently
from
6503450 to
c0c7fa0
Compare
krzywon
reviewed
Mar 24, 2025
Comment on lines
+10
to
+14
| - id: ruff | ||
| args: [--fix, --exit-non-zero-on-fix] | ||
| files: "sasdata/fair_database/.*" | ||
| - id: ruff-format | ||
| files: "sasdata/fair_database/.*" |
Collaborator
There was a problem hiding this comment.
Relevant discussion: https://github.com/orgs/SasView/discussions/3171
backmari
reviewed
Mar 27, 2025
backmari
reviewed
Apr 9, 2025
backmari
reviewed
Apr 9, 2025
backmari
reviewed
Apr 11, 2025
backmari
reviewed
Apr 11, 2025
krzywon
reviewed
Apr 21, 2025
|
If there are no more planned changes to the models, maybe we should delete the migrations and create new initial migrations based on the current state of the models. It definitely made sense to keep all intermediate migrations while the models were being developed, but this is probably a good place to start fresh. |
DrPaulSharp
force-pushed
the
refactor_24
branch
2 times, most recently
from
a16b0a6 to
e27d0cc
Compare
DrPaulSharp
force-pushed
the
refactor_24
branch
from
6e3ba34 to
c010919
Compare
DrPaulSharp
force-pushed
the
refactor_24
branch
2 times, most recently
from
d4683bd to
3df6e01
Compare
DrPaulSharp
force-pushed
the
refactor_24
branch
2 times, most recently
from
b32dbfe to
6f3b4af
Compare
rprospero
force-pushed
the
refactor_24
branch
from
490cec4 to
ee6af02
Compare
DrPaulSharp
force-pushed
the
refactor_24
branch
from
ee6af02 to
15acac0
Compare
DrPaulSharp
force-pushed
the
sasview-database
branch
from
19dd78f to
09b87ee
Compare
![codescene-delta-analysis[bot]](https://avatars.githubusercontent.com/in/53921?s=60&v=4){kind=small}
There was a problem hiding this comment.
No quality gates enabled for this code.
See analysis details in CodeScene
Absence of Expected Change Pattern
- sasdata/sasdata/dataloader/readers/danse_reader.py is usually changed with: sasdata/sasdata/dataloader/readers/tiff_reader.py
Quality Gate Profile: Custom Configuration
Install CodeScene MCP: safeguard and uplift AI-generated code. Catch issues early with our IDE extension and CLI tool.
DrPaulSharp
force-pushed
the
sasview-database
branch
from
09b87ee to
1c4aacc
Compare
Collaborator
|
The latest rebase now has this changing many files in refactor_24 that weren't there before. This is not mergeable in its current state, but I'll get it over the line during the hackathon next week. |
DrPaulSharp
force-pushed
the
refactor_24
branch
3 times, most recently
from
90413d7 to
dd691e0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Database backend in progress.