Skip to content

⚡ Bolt: Remove unnecessary String allocation in parser segments - #5

Open
SayanthRock wants to merge 1 commit into
mainfrom
bolt-optimize-segment-alloc-13891729391651992783
Open

⚡ Bolt: Remove unnecessary String allocation in parser segments#5
SayanthRock wants to merge 1 commit into
mainfrom
bolt-optimize-segment-alloc-13891729391651992783

Conversation

@SayanthRock

@SayanthRock SayanthRock commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

User description

💡 What: Refactored the internal Segment struct in rockql-parser to hold a reference to the original source text (&'a str) instead of allocating a new owned String.

🎯 Why: Previously, splitting the query source string into segments by the | character would allocate a new String object on the heap for every single segment. By pointing back to the original source string slice, we completely avoid these heap allocations.

📊 Impact: Reduces memory usage and CPU time during the initial lexing/segmenting phase of the parser. It completely eliminates heap allocation for all valid query segments, providing a significant boost for large queries or high-throughput parse servers.

🔬 Measurement: You can verify the optimization by profiling the memory allocations using a tool like Valgrind/DHAT, or running micro-benchmarks on the parse method. We can observe the elimination of String::to_owned calls in the parse pipeline.


PR created automatically by Jules for task 13891729391651992783 started by @SayanthRock


CodeAnt-AI Description

Reduce memory use while parsing pipeline queries

What Changed

  • Pipeline segments now reuse the original query text instead of creating a separate copy for each segment
  • Parsing behavior and source locations remain unchanged

Impact

✅ Lower memory during large query parsing
✅ Faster pipeline parsing
✅ Fewer temporary allocations

💡 Usage Guide

Checking Your Pull Request

Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.

Talking to CodeAnt AI

Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:

@codeant-ai ask: Your question here

This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.

Example

@codeant-ai ask: Can you suggest a safer alternative to storing this secret?

Preserve Org Learnings with CodeAnt

You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:

@codeant-ai: Your feedback here

This helps CodeAnt AI learn and adapt to your team's coding style and standards.

Example

@codeant-ai: Do not flag unused imports.

Retrigger review

Ask CodeAnt AI to review the PR again, by typing:

@codeant-ai: review

Check Your Repository Health

To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.

Summary by CodeRabbit

  • Performance
    • Reduced memory allocations during query parsing.
    • Improved efficiency when splitting and processing query segments.

Co-authored-by: SayanthRock <202829406+SayanthRock@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Copilot AI lite review requested due to automatic review settings August 5, 2026 21:42
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@codeant-ai

codeant-ai Bot commented Aug 5, 2026

Copy link
Copy Markdown

🤖 CodeAnt AI — Review Status

Status Commit Started (UTC) Finished (UTC)
✅ Reviewed your PR 655bf17 Aug 05, 2026 · 21:42 21:44

@codeant-ai

codeant-ai Bot commented Aug 5, 2026

Copy link
Copy Markdown

Thanks for using CodeAnt! 🎉

We're free for open-source projects. if you're enjoying it, help us grow by sharing.

Share on X ·
Reddit ·
LinkedIn

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@ai-coding-guardrails

Copy link
Copy Markdown

You've hit your review limit for the week, but don't worry you'll get some more next week!

Contact us at hello@zenable.io if you want this rate limit to go away

@codeant-ai codeant-ai Bot added the size:S This PR changes 10-29 lines, ignoring generated files label Aug 5, 2026
@coderabbitai

coderabbitai Bot commented Aug 5, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: abec7d54-144f-4784-9fc5-b530feb7113c

📥 Commits

Reviewing files that changed from the base of the PR and between 87532a0 and 655bf17.

📒 Files selected for processing (1)
  • compiler/rockql-parser/src/lib.rs

📝 Walkthrough

Walkthrough

The parser now stores query segments as borrowed string slices. Segment splitting and construction propagate the source lifetime, and transformation parsing passes the borrowed text directly.

Changes

Segment Text Borrowing

Layer / File(s) Summary
Borrowed segment pipeline
compiler/rockql-parser/src/lib.rs
Segment, split_segments, and push_segment now propagate borrowed query text. Transformation parsing uses the borrowed segment text directly.

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested reviewers: copilot

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main change: removing unnecessary String allocations from parser segments.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch bolt-optimize-segment-alloc-13891729391651992783

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S This PR changes 10-29 lines, ignoring generated files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants