nip4: Add version 9.1.5#17871
Merged
Merged
Conversation
📝 WalkthroughWalkthroughThis PR updates the nip4 package manifest (bucket/nip4.json) to version 9.1.5, replacing the 64bit and arm64 release URLs and their SHA256 hashes; all other manifest fields and the autoupdate templates are unchanged. Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
bucket/nip4.json (1)
23-33: Run the standard Scoop manifest validation flow before merge.Please validate locally with:
scoop config debug true scoop config gh_token <your-github-token> # optional, read-only token for GitHub API .\bin\checkver.ps1 -App nip4 -f .\bin\formatjson.ps1 -App nip4 scoop install .\bucket\nip4.json -a 64bit scoop uninstall nip4 scoop install .\bucket\nip4.json -a arm64If anything is unclear, use:
- Contribution Guide: https://github.com/ScoopInstaller/.github/blob/main/.github/CONTRIBUTING.md
- App Manifests Wiki: https://github.com/ScoopInstaller/Scoop/wiki/App-Manifests
As per coding guidelines: "Provide clear instructions for testing the manifest locally before submission" and "always provide a link to the official contribution guide or wiki."
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@bucket/nip4.json` around lines 23 - 33, The nip4.json manifest's checkver/autoupdate block needs local validation and formatting before merge; run the standard Scoop manifest validation flow for the nip4 manifest: enable debug and (optionally) GH token, then run .\bin\checkver.ps1 -App nip4 -f, .\bin\formatjson.ps1 -App nip4, and test installs/uninstalls for both architectures with scoop install .\bucket\nip4.json -a 64bit / uninstall / scoop install .\bucket\nip4.json -a arm64 to confirm the "checkver" and "autoupdate" entries work as intended; follow the Contribution Guide (https://github.com/ScoopInstaller/.github/blob/main/.github/CONTRIBUTING.md) and App Manifests Wiki (https://github.com/ScoopInstaller/Scoop/wiki/App-Manifests) if anything is unclear.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@bucket/nip4.json`:
- Around line 23-33: The nip4.json manifest's checkver/autoupdate block needs
local validation and formatting before merge; run the standard Scoop manifest
validation flow for the nip4 manifest: enable debug and (optionally) GH token,
then run .\bin\checkver.ps1 -App nip4 -f, .\bin\formatjson.ps1 -App nip4, and
test installs/uninstalls for both architectures with scoop install
.\bucket\nip4.json -a 64bit / uninstall / scoop install .\bucket\nip4.json -a
arm64 to confirm the "checkver" and "autoupdate" entries work as intended;
follow the Contribution Guide
(https://github.com/ScoopInstaller/.github/blob/main/.github/CONTRIBUTING.md)
and App Manifests Wiki
(https://github.com/ScoopInstaller/Scoop/wiki/App-Manifests) if anything is
unclear.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 38549a4b-b807-4819-a339-fc07c1e5a182
📒 Files selected for processing (1)
bucket/nip4.json
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Contributor
Author
|
/verify |
Contributor
|
All changes look good. Wait for review from human collaborators. nip4
|
There was a problem hiding this comment.
🧹 Nitpick comments (1)
bucket/nip4.json (1)
2-33: Run local manifest checks before merge.Use the standard Scoop validation flow for
nip4:scoop config debug true scoop config gh_token <your-github-token> # read-only, optional for GitHub API rate limits .\bin\checkver.ps1 -App nip4 -f .\bin\formatjson.ps1 -App nip4 scoop install .\bucket\nip4.json -a 64bit scoop install .\bucket\nip4.json -a arm64References:
- https://github.com/ScoopInstaller/.github/blob/main/.github/CONTRIBUTING.md
- https://github.com/ScoopInstaller/Scoop/wiki/App-Manifests
As per coding guidelines, provide clear local testing steps (
checkver,formatjson, and per-architecture install) for Scoop manifests.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@bucket/nip4.json` around lines 2 - 33, Add local validation and install test steps for the nip4 manifest: run the Scoop checkver/formatjson flow and perform per-architecture installs to ensure autoupdate and URLs work and the bin/shortcuts are correct. Specifically, run checkver (.\bin\checkver.ps1 -App nip4 -f) to validate version detection, run formatjson (.\bin\formatjson.ps1 -App nip4) to normalize the manifest, then attempt installs for both architectures (scoop install .\bucket\nip4.json -a 64bit and -a arm64) to confirm the 64bit/arm64 "url" templates under "autoupdate" and the "bin" / "shortcuts" entries are valid; include these steps in the PR description so reviewers can reproduce locally.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@bucket/nip4.json`:
- Around line 2-33: Add local validation and install test steps for the nip4
manifest: run the Scoop checkver/formatjson flow and perform per-architecture
installs to ensure autoupdate and URLs work and the bin/shortcuts are correct.
Specifically, run checkver (.\bin\checkver.ps1 -App nip4 -f) to validate version
detection, run formatjson (.\bin\formatjson.ps1 -App nip4) to normalize the
manifest, then attempt installs for both architectures (scoop install
.\bucket\nip4.json -a 64bit and -a arm64) to confirm the 64bit/arm64 "url"
templates under "autoupdate" and the "bin" / "shortcuts" entries are valid;
include these steps in the PR description so reviewers can reproduce locally.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: a4ffc4a4-c109-4ea0-b1da-2763254fed21
📒 Files selected for processing (1)
bucket/nip4.json
Contributor
Author
|
@z-Fng This is now finally ready for review! The maintainers fixed the release process. |
z-Fng
approved these changes
Jun 4, 2026
Member
z-Fng
left a comment
z-Fng
left a comment
There was a problem hiding this comment.
Thank you for your contribution!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #17870
<manifest-name[@version]|chore>: <general summary of the pull request>