Skip to content

Clamp beacon envelope pagination limit #5679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dazer1234 wants to merge 2 commits into
base: main
Choose a base branch
from
+11 −1
Open

Clamp beacon envelope pagination limit #5679

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bc44712
Clamp beacon envelope pagination limit
dazer1234 May 18, 2026
b44760a
Fix beacon envelope limit test mock
dazer1234 May 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion node/rustchain_v2_integrated_v2.2.1_rip200.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8365,7 +8365,7 @@ def beacon_digest():
@app.route("/beacon/envelopes", methods=["GET"])
def beacon_envelopes_list():
try:
limit = min(int(request.args.get("limit", 50)), 50)
limit = max(1, min(int(request.args.get("limit", 50)), 50))
offset = max(int(request.args.get("offset", 0)), 0)
except (ValueError, TypeError):
limit, offset = 50, 0
Expand Down
10 changes: 10 additions & 0 deletions node/tests/test_limit_validation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,16 @@ def test_pending_list_clamps_negative_limit(self):
self.assertEqual(resp.get_json(), {"ok": True, "count": 0, "pending": []})
self.assertEqual(mock_db.execute.call_args.args[1], ("pending", 1))

def test_beacon_envelopes_clamps_negative_limit(self):
with patch.object(self.mod, "get_recent_envelopes", return_value=[]) as get_recent_envelopes:
resp = self.client.get("/beacon/envelopes?limit=-1&offset=-5")

self.assertEqual(resp.status_code, 200)
self.assertEqual(resp.get_json(), {"ok": True, "count": 0, "envelopes": []})
get_recent_envelopes.assert_called_once_with(
limit=1, offset=0, db_path=self.mod.DB_PATH
)


if __name__ == "__main__":
unittest.main()