Add focus to the given property in list of relevant implications#181
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On the property detail page, all relevant implications for that property are listed. However, they are currently displayed in their full form, which means that conclusions unrelated to the given property are also shown. This PR removes those irrelevant conclusions.
Specifically, if an implication (that is not an equivalence) has P among its conclusions, then only P is shown as the conclusion. The remaining conclusions are omitted, since they are not relevant in this context. Of course, the detail page for that implication still has all conclusions.
Examples
On the detail page for epi-regular, the implication
elementary topos -> disjoint finite coproducts + effective congruences + epi-regular + finitely cocompleteis abbreviated toelementary topos -> epi-regular.On the detail page for products, the implication
CIP -> coproducts + products + zero morphismsis abbreviated toCIP -> products.On the detail page for powers, the implication*
products -> countable products + powersis abbreviated toproducts -> powers.*This implication was listed as
products => countable products + finite products + powers. I removed the "finite products" since this is a consequence of "countable products" already.