Update dependencies#108
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the project’s minimum required version of vllm to a newer release.
Changes:
- Bump
vllmdependency constraint from>=0.18.1to>=0.19.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "datasets>=4.4.1", | ||
| "gimkit>=0.1.1", | ||
| "vllm>=0.18.1", | ||
| "vllm>=0.19", |
There was a problem hiding this comment.
For consistency with the other dependency specifiers in this file (which use fully-qualified versions like x.y.z), consider using an explicit patch version here as well (e.g., >=0.19.0 or the specific minimum you validated). >=0.19 is valid per PEP 440 but is less precise/readable than the surrounding entries.
Suggested change
| "vllm>=0.19", | |
| "vllm>=0.19.0", |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.