Conversation
There was a problem hiding this comment.
Pull request overview
Adds a new API/RPC to swap indexing pipelines between two indexes on different indexers, with validation to prevent inconsistent swaps and an atomic plan update in the control plane.
Changes:
- Add REST
POST /api/v1/indexing/swap-pipelineshandler forwarding to the control plane client. - Extend ControlPlaneService proto/Rust client/server with
SwapIndexingPipelinesRPC +RpcName. - Implement swap logic in
IndexingScheduler(validate + apply) and add targeted unit tests.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| quickwit/quickwit-serve/src/rest.rs | Wires the new swap endpoint into the API v1 route tree. |
| quickwit/quickwit-serve/src/indexing_api/rest_handler.rs | Adds warp filter + endpoint function for swapping pipelines via control-plane client. |
| quickwit/quickwit-serve/src/indexing_api/mod.rs | Re-exports the new REST handler. |
| quickwit/quickwit-proto/protos/quickwit/control_plane.proto | Defines SwapIndexingPipelines RPC and request/response messages. |
| quickwit/quickwit-proto/src/codegen/quickwit/quickwit.control_plane.rs | Generated Rust code for the new RPC/messages and tower/grpc plumbing. |
| quickwit/quickwit-proto/src/control_plane/mod.rs | Registers RpcName for the new request type. |
| quickwit/quickwit-control-plane/src/indexing_scheduler/mod.rs | Implements validated swap logic and adds tests covering success/failure/contradictions. |
| quickwit/quickwit-control-plane/src/control_plane.rs | Adds actor handler to route swap requests into the indexing scheduler. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Darkheir
force-pushed
the
feat/pipelines_swap
branch
from
46b3713 to
789ddbe
Compare
Signed-off-by: Darkheir <raphael.cohen@sekoia.io>
Darkheir
force-pushed
the
feat/pipelines_swap
branch
from
789ddbe to
901d3e5
Compare
rdettai-sk
reviewed
Apr 15, 2026
Signed-off-by: Darkheir <raphael.cohen@sekoia.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add a new endpoint allowing to swap the pipelines of 2 indexes located on different nodes.
Both indexes must have the same number of pipelines running on the nodes.
Various check are made to ensure that the swap can't create any issues.
The ControlPlane actor processes messages strictly sequentially so swapping pipelines should not encounter any concurrency issue.