[merging June 30 at 4pm PT] making this an hard guideline & enforcing consistent reviews on upstream sglang/vllm docker repo to PR CheckList#1956
Merged
functionstackx merged 4 commits intoJul 4, 2026
Conversation
Corrected duplicate checklist items and improved clarity.
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
Removed duplicate checklist item regarding vLLM/SGLang support verification.
functionstackx
changed the title
Removed duplicate checklist item regarding vLLM/SGLang verification.
Updated checklist item for verifying vLLM/SGLang support claims to clarify the requirement for upstream in-tree submissions.
functionstackx
changed the title
functionstackx
deleted the
enforcing-consistent-reviews-on-upstream-docker
branch
functionstackx
added a commit
that referenced
this pull request
Jul 4, 2026
….md (#2015) Adds four checks to the sign-off verifier prompt to cover the checklist items introduced in #1956 and #2011 (plus previously unverified items): - Check 5: sign-off uses the latest PR_REVIEW_CHECKLIST.md template - Check 6: upstream vllm/lmsysorg Docker Hub images on established SKUs (H100/H200/B200/B300/GB200/GB300, MI300X/MI325X/MI355X), and vLLM/SGLang submissions before additional frameworks - Check 7: no benchmark hacks that change model architecture / cut FLOPs - Check 8: spec-decode configs benchmark through chat templates Also fixes the stale '(0-3)' check-range reference and updates the header summary and verdict rules to cover checks 0-8. Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this is always been an soft guideline since april ish as communicated with AMD Bill he (as they were the only ones that weren't doing upstream sglang/vllm), but in order to turn this into an hard guideline, we r now adding it to the public
PR_CHECKLIST.mdto ensure consistent enforcement of PR reviews via the checklist