-
Notifications
You must be signed in to change notification settings - Fork 217
Update DSV4 GB300 Dynamo vLLM Recipes #2010
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
hjjq
wants to merge
2
commits into
main
Choose a base branch
from
hjjq/dsv4-gb300-vllm
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟡 The new
dsv4-fp4-gb300-dynamo-vllmentry inperf-changelog.yaml(line 4441) haspr-link: https://github.com/SemiAnalysisAI/InferenceX/pull/XXX— a template placeholder that wasn't filled in. This should be.../pull/2010to match the actual PR number, consistent with every other entry in the file.Extended reasoning...
What the bug is
The new entry added at the bottom of
perf-changelog.yamlfordsv4-fp4-gb300-dynamo-vllmuses a literal placeholder for itspr-link:The
XXXis clearly a fill-in-the-blank the author forgot to substitute. Every other entry in this file uses a concrete numeric PR (e.g.pull/2001,pull/1990,pull/1978,pull/1975). This PR is #2010, so it should readhttps://github.com/SemiAnalysisAI/InferenceX/pull/2010.Why existing tooling doesn't catch this on the PR
utils/validate_perf_changelog.pyexplicitly allows the placeholder on PR runs (via aPR_LINK_PLACEHOLDERSset) so that authors can open the PR before knowing the assigned number. That is why CI is green here.Impact after merge
On main-branch runs,
validate_added_pr_link()enforcesCANONICAL_PR_LINK = r'https://github\.com/SemiAnalysisAI/InferenceX/pull/\d+'withfullmatch.XXXdoes not match\d+, so if this merges as-is, the next main-branch changelog validation will fail on this entry. Beyond that, the entry becomes useless as a tracking record — clicking the link goes to a 404, and the change loses its anchor to the PR that introduced it.Step-by-step proof
pr-link: https://github.com/SemiAnalysisAI/InferenceX/pull/XXX.validate_added_pr_linksees the link is inPR_LINK_PLACEHOLDERS→ passes.main,validate_added_pr_linkruns and executesCANONICAL_PR_LINK.fullmatch(link)with the pattern^https://github\.com/SemiAnalysisAI/InferenceX/pull/\d+$..../pull/XXXfails\d+→fullmatchreturnsNone→ the check errors out.Fix
Replace
pull/XXXwithpull/2010on line 4441 before merging.Severity
Nit — it does not affect runtime/benchmark behavior and is a one-character fix, but it should be corrected before merge so the changelog stays consistent and main-branch validation stays green.