[Klaud Cold][DO NOT MERGE] Test signoff-verify Check 7 with --hf-overrides indexer hack#2017
[Klaud Cold][DO NOT MERGE] Test signoff-verify Check 7 with --hf-overrides indexer hack#2017functionstackx wants to merge 1 commit into
Conversation
…merge) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Thanks for the contribution! Please reach out to respective companies' CODEOWNER to fill in the latest PR_REVIEW_CHECKLIST.md before pinging core maintainer on Slack for review. PR authors are responsible for ensuring that after merging, all GitHub Action jobs fully pass. A lot of the time, failures are just flakes and simply re-running the failed jobs will fix it. See GitHub's docs on re-running failed jobs 感谢你的贡献!请联系相应公司的 CODEOWNER 填写最新的 PR_REVIEW_CHECKLIST.md,然后再在 Slack 上联系核心维护者进行审阅。 PR 作者有责任确保合并后所有 GitHub Action 任务完全通过。 很多时候失败只是偶发抖动(flake),重新运行失败的任务即可解决。参见 GitHub 关于重新运行失败任务的文档 |
|
As a PR reviewer and CODEOWNER, I have reviewed this and have:
Additional detail section:Signed: |
|
@functionstackx Sign-off NOT verified — merge is blocked: no sweep/evals ran on any commit in this PR, no
Note: the PR is titled "[DO NOT MERGE] Test signoff-verify Check 7" and describes itself as a negative test for this workflow. |
|
Negative test confirmed — Check 7 correctly FAILed on the |
Summary
--hf-overrides '{"use_index_cache": true, "index_topk_freq": 4}'to the MiniMax M3 MXFP8 H200 vLLM launch command — an architecture-changing benchmark hack of exactly the kinddocs/PR_REVIEW_CHECKLIST.mdforbids.codeowner-signoff-verifyworkflow ([Klaud Cold] Align codeowner-signoff-verify with latest PR_REVIEW_CHECKLIST.md #2015): after a sign-off comment is posted, Check 7 should FAIL naming this flag.🤖 Generated with Claude Code