[Klaud Cold][DO NOT MERGE] Test signoff-verify Check 6 with vendor rocm/sgl-dev image on MI300X#2018
[Klaud Cold][DO NOT MERGE] Test signoff-verify Check 6 with vendor rocm/sgl-dev image on MI300X#2018functionstackx wants to merge 1 commit into
Conversation
…t merge) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Thanks for the contribution! Please reach out to respective companies' CODEOWNER to fill in the latest PR_REVIEW_CHECKLIST.md before pinging core maintainer on Slack for review. PR authors are responsible for ensuring that after merging, all GitHub Action jobs fully pass. A lot of the time, failures are just flakes and simply re-running the failed jobs will fix it. See GitHub's docs on re-running failed jobs 感谢你的贡献!请联系相应公司的 CODEOWNER 填写最新的 PR_REVIEW_CHECKLIST.md,然后再在 Slack 上联系核心维护者进行审阅。 PR 作者有责任确保合并后所有 GitHub Action 任务完全通过。 很多时候失败只是偶发抖动(flake),重新运行失败的任务即可解决。参见 GitHub 关于重新运行失败任务的文档 |
2 similar comments
|
Thanks for the contribution! Please reach out to respective companies' CODEOWNER to fill in the latest PR_REVIEW_CHECKLIST.md before pinging core maintainer on Slack for review. PR authors are responsible for ensuring that after merging, all GitHub Action jobs fully pass. A lot of the time, failures are just flakes and simply re-running the failed jobs will fix it. See GitHub's docs on re-running failed jobs 感谢你的贡献!请联系相应公司的 CODEOWNER 填写最新的 PR_REVIEW_CHECKLIST.md,然后再在 Slack 上联系核心维护者进行审阅。 PR 作者有责任确保合并后所有 GitHub Action 任务完全通过。 很多时候失败只是偶发抖动(flake),重新运行失败的任务即可解决。参见 GitHub 关于重新运行失败任务的文档 |
|
Thanks for the contribution! Please reach out to respective companies' CODEOWNER to fill in the latest PR_REVIEW_CHECKLIST.md before pinging core maintainer on Slack for review. PR authors are responsible for ensuring that after merging, all GitHub Action jobs fully pass. A lot of the time, failures are just flakes and simply re-running the failed jobs will fix it. See GitHub's docs on re-running failed jobs 感谢你的贡献!请联系相应公司的 CODEOWNER 填写最新的 PR_REVIEW_CHECKLIST.md,然后再在 Slack 上联系核心维护者进行审阅。 PR 作者有责任确保合并后所有 GitHub Action 任务完全通过。 很多时候失败只是偶发抖动(flake),重新运行失败的任务即可解决。参见 GitHub 关于重新运行失败任务的文档 |
|
As a PR reviewer and CODEOWNER, I have reviewed this and have:
Additional detail section:Signed: |
|
@functionstackx Sign-off REJECTED — vendor image on established hardware, no passing sweep/evals on any in-PR commit, no
Note: the PR is titled "[DO NOT MERGE]" and self-describes as a negative test of this workflow. |
|
Negative test confirmed — Check 6 correctly FAILed on the vendor |
Summary
dsr1-fp8-mi300x-sglangfrom upstreamlmsysorg/sglang:v0.5.12-rocm700-mi30xto vendor forkrocm/sgl-dev:sglang-0.5.12-rocm700-mi30x.codeowner-signoff-verifyworkflow ([Klaud Cold] Align codeowner-signoff-verify with latest PR_REVIEW_CHECKLIST.md #2015): MI300X is established hardware and DeepSeek-R1 is upstream-supported, so Check 6(a) should FAIL naming the non-upstream image.🤖 Generated with Claude Code