[codex] Allow combined trace and turn idle caps#11
Draft
cquil11 wants to merge 2 commits into
Draft
Conversation
Try out this PRQuick install: pip install --upgrade --force-reinstall git+https://github.com/ai-dynamo/aiperf.git@230e3d5559bf32ff7a5232a6e5e15fd991278565Recommended with virtual environment (using uv): uv venv --python 3.12 && source .venv/bin/activate
uv pip install --upgrade --force-reinstall git+https://github.com/ai-dynamo/aiperf.git@230e3d5559bf32ff7a5232a6e5e15fd991278565Last updated for commit: |
|
Fern Docs Preview: generation failed — see the Actions log for details. This does not block merge; ask a maintainer to retry if needed. |
This reverts commit c46dc19.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Allows Weka / AgentX replay to use both idle-gap controls together:
trace_idle_gap_cap_secondscompresses aggregate request-start idle gaps within each root trace first.inter_turn_delay_cap_secondsthen caps the derived per-stream parent/subagent delays.This restores separate control over engine-idle gaps and per-conversation dormancy, matching the behavior discussed for AgentX trace replay experiments.
Details
Previously, enabling
trace_idle_gap_cap_secondsdisabled the per-turn delay cap to avoid accidental double-capping. That made it impossible to express policies like:where the benchmark keeps the engine moving while still bounding long per-conversation gaps.
This PR updates the Weka loader semantics, scenario/config descriptions, generated CLI docs, and regression tests for serial/parallel conversion parity.
Validation
uv run pytest tests/unit/dataset/loader/test_weka_trace.py::test_trace_idle_gap_cap_is_per_trace_and_uses_request_starts tests/unit/dataset/loader/test_weka_flat_split_parallel_adv.py::test_convert_fanout_idle_gap_warp_parallel_byte_identical tests/unit/dataset/loader/test_weka_flat_split_parallel_adv.py::test_convert_think_time_only_with_delay_cap_parallel_byte_identical tests/unit/dataset/loader/test_delay_cap.py tests/unit/common/scenario/test_scenario_validator.py::test_inter_turn_delay_cap_explicit_other_value_does_not_raise tests/unit/common/scenario/test_scenario_registry.pyuv run ruff check src/aiperf/common/config/loadgen_config.py src/aiperf/common/scenario/base.py src/aiperf/dataset/loader/weka_trace.py tests/unit/common/scenario/test_scenario_validator.py tests/unit/dataset/loader/test_weka_flat_split_parallel_adv.py tests/unit/dataset/loader/test_weka_trace.pyuv run ruff format --check src/aiperf/common/config/loadgen_config.py src/aiperf/common/scenario/base.py src/aiperf/dataset/loader/weka_trace.py tests/unit/common/scenario/test_scenario_validator.py tests/unit/dataset/loader/test_weka_flat_split_parallel_adv.py tests/unit/dataset/loader/test_weka_trace.py