Merged
Conversation
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…o feature/multi-bucket
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add multi-bucket / multi-IAM-role support by adding cached per-role S3 sessions
Changes:
S3Session+ session registry toS3MPConfigto support cached per-role S3 clients/resources.MirrorPathwith bucket_key and iam_role_arn, and route S3 operations through the instance’s session/bucket/client.s3_urlparsing and ans3_urlproperty onMirrorPathPR Checklist
pyproject.toml.Breaking Changes
Hopefully not too much, I tried to make it backwards compatible