Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes folder-oriented S3 operations so that uploads don’t generate malformed keys and deletions properly recurse through nested “folders” (prefixes), with additional teardown/cleanup to keep S3-backed tests isolated.
Changes:
- Prevent double slashes when uploading directory contents to a trailing-slash S3 key/prefix.
- Make S3 “folder” deletion recurse into nested prefixes and remove folder marker objects.
- Update
MirrorPath.upload_from_mirrorto upload folders recursively (and add regression tests + test teardown cleanups).
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
S3MP/utils/s3_utils.py |
Fixes folder upload key joining and implements recursive deletion of nested prefixes. |
S3MP/mirror_path.py |
Updates mirror upload to handle folders recursively rather than skipping when the prefix exists. |
tests/test_s3_utils.py |
Adds regression tests for folder upload/delete behavior and adds fixture teardown cleanup. |
tests/test_mirror_path.py |
Adds regression tests for folder uploads via MirrorPath and adds teardown cleanup. |
tests/test_prefix_queries.py |
Adds fixture teardown cleanup to avoid S3 test data leakage across tests. |
pyproject.toml |
Bumps project version to 0.9.1. |
uv.lock |
Updates lockfile version entry for s3mp to 0.9.1. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
PR Checklist
pyproject.toml.Breaking Changes