Skip to content

fix/folder-upload#35

Merged
TrevorBurgoyne merged 2 commits intomasterfrom
fix/folder-upload
Mar 24, 2026
Merged

fix/folder-upload#35
TrevorBurgoyne merged 2 commits intomasterfrom
fix/folder-upload

Conversation

@TrevorBurgoyne
Copy link
Copy Markdown
Member

Description

  • Fix folder upload/deletion recursive logic

PR Checklist

  • Merged latest master
  • Updated version number in pyproject.toml.
  • Added tests for new features or bug fixes.
  • Passed all tests
  • Update README.md if needed.

Breaking Changes

@TrevorBurgoyne TrevorBurgoyne requested a review from Copilot March 24, 2026 22:04
@github-actions github-actions bot added the bug Something isn't working label Mar 24, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes folder-oriented S3 operations so that uploads don’t generate malformed keys and deletions properly recurse through nested “folders” (prefixes), with additional teardown/cleanup to keep S3-backed tests isolated.

Changes:

  • Prevent double slashes when uploading directory contents to a trailing-slash S3 key/prefix.
  • Make S3 “folder” deletion recurse into nested prefixes and remove folder marker objects.
  • Update MirrorPath.upload_from_mirror to upload folders recursively (and add regression tests + test teardown cleanups).

Reviewed changes

Copilot reviewed 6 out of 7 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
S3MP/utils/s3_utils.py Fixes folder upload key joining and implements recursive deletion of nested prefixes.
S3MP/mirror_path.py Updates mirror upload to handle folders recursively rather than skipping when the prefix exists.
tests/test_s3_utils.py Adds regression tests for folder upload/delete behavior and adds fixture teardown cleanup.
tests/test_mirror_path.py Adds regression tests for folder uploads via MirrorPath and adds teardown cleanup.
tests/test_prefix_queries.py Adds fixture teardown cleanup to avoid S3 test data leakage across tests.
pyproject.toml Bumps project version to 0.9.1.
uv.lock Updates lockfile version entry for s3mp to 0.9.1.

@TrevorBurgoyne TrevorBurgoyne merged commit 9adec21 into master Mar 24, 2026
1 check passed
@TrevorBurgoyne TrevorBurgoyne deleted the fix/folder-upload branch March 24, 2026 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants