Skip to content

Universal XMP Tags #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joeyfranck56 merged 7 commits into from
Dec 1, 2025
Merged

Universal XMP Tags #89

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
68341ba
make generic xmp tags universal to allow for new cameras to be more e…
Nov 5, 2025
a19431c
make generic xmp tags universal to allow for new cameras to be more e…
Nov 5, 2025
1b13ba2
update mypy file
Nov 5, 2025
cfa4c19
add ignore back
Nov 5, 2025
e9aa654
remove ignore comment
Nov 24, 2025
49ea705
update XMP tag doc string
Nov 24, 2025
dc1174a
add back ignore
Nov 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 4 additions & 18 deletions imgparse/xmp_tags.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,12 +14,12 @@ class XMPTags:
PITCH: str = ""
YAW: str = ""
FOCAL_LEN: str = ""
WAVELENGTH_CENTRAL: str = ""
WAVELENGTH_FWHM: str = ""
BANDNAME: str = ""
WAVELENGTH_CENTRAL: str = "Camera:CentralWavelength"
WAVELENGTH_FWHM: str = "Camera:WavelengthFWHM"
BANDNAME: str = "Camera:BandName"
LRF_ALT: str = ""
LRF_ALT2: str = "" # See SenteraTags below
ILS: str = ""
ILS: str = "Camera:SunSensor"
HOMEPOINT_LAT: str = ""
HOMEPOINT_LON: str = ""
PRINCIPAL_POINT: str = ""
Expand All @@ -39,12 +39,8 @@ class SenteraTags(XMPTags):
PITCH = "Camera:Pitch"
YAW = "Camera:Yaw"
FOCAL_LEN = "Camera:PerspectiveFocalLength"
WAVELENGTH_CENTRAL = "Camera:CentralWavelength"
WAVELENGTH_FWHM = "Camera:WavelengthFWHM"
BANDNAME = "Camera:BandName"
LRF_ALT = "Sentera:AltimeterCalculatedAGL"
LRF_ALT2 = "Sentera:AltimeterCalcuatedAGL" # l was left out in Quad v1.0.0
ILS = "Camera:SunSensor"
HOMEPOINT_LAT = "SENTERA:HomePointLatitude"
HOMEPOINT_LON = "SENTERA:HomePointLongitude"
PRINCIPAL_POINT = "Camera:PrincipalPoint"
Expand All @@ -61,11 +57,7 @@ class DJITags(XMPTags):
PITCH = "drone-dji:GimbalPitchDegree"
YAW = "drone-dji:GimbalYawDegree"
FOCAL_LEN = "drone-dji:CalibratedFocalLength"
WAVELENGTH_CENTRAL = "Camera:CentralWavelength"
WAVELENGTH_FWHM = "Camera:WavelengthFWHM"
BANDNAME = "Camera:BandName"
SELF_DATA = "drone-dji:SelfData"
ILS = "Camera:SunSensor"
IRRADIANCE = "Camera:Irradiance"
CAPTURE_UUID = "drone-dji:CaptureUUID"
DEWARP_FLAG = "drone-dji:DewarpFlag"
Expand All @@ -75,17 +67,11 @@ class DJITags(XMPTags):
class MicaSenseTags(XMPTags):
"""MicaSense XMP Tags."""

WAVELENGTH_CENTRAL = "Camera:CentralWavelength"
WAVELENGTH_FWHM = "Camera:WavelengthFWHM"
BANDNAME = "Camera:BandName"
CAPTURE_UUID = "MicaSense:CaptureId"
IRRADIANCE = "Camera:Irradiance"


class ParrotTags(XMPTags):
"""Parrot XMP Tags."""

WAVELENGTH_CENTRAL = "Camera:CentralWavelength"
WAVELENGTH_FWHM = "Camera:WavelengthFWHM"
BANDNAME = "Camera:BandName"
CAPTURE_UUID = "Camera:CaptureUUID"
1 change: 1 addition & 0 deletions mypy.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,3 +4,4 @@ namespace_packages = True
explicit_package_bases = True
scripts_are_modules = True
strict = True
warn_unused_ignores = False
Copy link
Copy Markdown
Member

@elliott-imhoff elliott-imhoff Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete the unused ignore comment instead of setting this

Copy link
Copy Markdown
Contributor Author

@joeyfranck56 joeyfranck56 Nov 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@elliott-imhoff Not sure whats up with this one, its passing in my local pre-commit environment but failing in the lint test: Fail

2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[tool.poetry]
name = "imgparse"
version = "2.0.7"
version = "2.0.8"
description = "Python image-metadata-parser utilities"
authors = []
include = [
Expand Down