Skip to content

fix(indexer): unblock testnet backfill#74

Merged
github-actions[bot] merged 1 commit into
mainfrom
fix/testnet-indexer-catchup
May 26, 2026
Merged

fix(indexer): unblock testnet backfill#74
github-actions[bot] merged 1 commit into
mainfrom
fix/testnet-indexer-catchup

Conversation

@satyakwok
Copy link
Copy Markdown
Member

@satyakwok satyakwok commented May 26, 2026

Summary

Test plan

  • [ ]

Related

Summary by CodeRabbit

  • New Features

    • Added explicit error handling for missing blocks with improved logging and graceful sync continuation.
  • Bug Fixes

    • Indexer now handles missing blocks gracefully instead of failing the batch.
    • Improved rate limit retry logic to only retry on HTTP 429 errors.
    • Added timeout protection for transaction fetching to improve reliability.
    • Ensured block sync height progresses monotonically forward.

Review Change Stack

@github-actions github-actions Bot enabled auto-merge (squash) May 26, 2026 07:51
@github-actions github-actions Bot merged commit 2d64432 into main May 26, 2026
7 of 8 checks passed
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 26, 2026

Caution

Review failed

Pull request was closed or merged during review

📝 Walkthrough

Walkthrough

This PR enhances the indexer's block-handling and error recovery by introducing RPC block parsing support, rewriting the chain client's getBlock to use raw JSON-RPC, and integrating missing-block error handling into the sync loop with monotonic height tracking. It adds a 10-second timeout to getNativeTransaction, improves 429 retry detection, and ensures last_synced_height advances monotonically via GREATEST comparisons. Configuration changes include making the Docker healthcheck port configurable and updating the testnet compose file to use host networking with explicit localhost endpoints for RPC and Postgres connections.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~22 minutes

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Description check ⚠️ Warning The pull request description is entirely empty template placeholders with no substantive content, test plan details, or related links provided. Fill in the Summary section (1-3 sentences explaining what changed and why), add a Test plan with specific test cases, and include any related issue/PR links.
Docstring Coverage ⚠️ Warning Docstring coverage is 25.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title 'fix(indexer): unblock testnet backfill' directly relates to the main change—enabling testnet indexing to progress past missing blocks by handling BlockNotFoundError.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/testnet-indexer-catchup

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

ESLint skipped: no ESLint configuration detected in root package.json. To enable, add eslint to devDependencies.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant