fix: tokio-tungstenite 0.29 Message API needs Utf8Bytes / Bytes#17
Conversation
The tokio-tungstenite 0.24 → 0.29 bump (#9) merged green because cargo check defaults ran without --all-features, missing the `bft` feature's two callsites: Message::Text(String) → Message::Text(Utf8Bytes) Message::Ping(Vec<u8>) → Message::Ping(Bytes) `s.into()` and `Default::default()` cover both. Behaviour identical.
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThis PR makes two focused updates to WebSocket message construction in the BFT driver. Line 267 changes how outbound text frames are built when forwarding Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Suggested labels
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Followup to #9 (tokio-tungstenite 0.24 → 0.29) which broke main behind the
bftfeature flag.Two callsites in src/bft.rs needed updating:
Message::Text(s)→Message::Text(s.into())(Utf8Bytes wrapper)Message::Ping(vec![])→Message::Ping(Default::default())(Bytes wrapper)Verified:
cargo check --all-featuresclean,cargo test --all-features10+1/11 pass.Summary by CodeRabbit