Add auth submetrics - #189
Open
maryna-shevchuk wants to merge 4 commits into
Open
Conversation
maryna-shevchuk
commented
Jul 20, 2026
maryna-shevchuk
commented
Collaborator
- Add auth submetrics. Submetrics only get computed when the agent actually calls an "auth" tool during the conversation:
- auth_first_try_success: 1.0 if authentication overall succeeded AND every auth tool was called exactly once (no retries needed); 0.0 if it succeeded but only after retrying an auth tool.
- auth_num_calls: average number of times each auth tool was called, but only counted when auth succeeded — tells you how many attempts it typically took to succeed.
- auth_num_calls_on_failure: same average call count, but for cases where auth ultimately failed — tells you how many attempts the agent wasted before giving up.
- Add unit tests for the submetrics.
JosephMarinier
approved these changes
Jul 22, 2026
JosephMarinier
left a comment
JosephMarinier
left a comment
Collaborator
There was a problem hiding this comment.
I only have small comments to simplify the code.
JosephMarinier
approved these changes
Jul 22, 2026
JosephMarinier
left a comment
JosephMarinier
left a comment
Collaborator
There was a problem hiding this comment.
Cool! This looks good to me. 👍
I only shared a few thoughts, maybe for future work.
JosephMarinier
approved these changes
Jul 27, 2026
JosephMarinier
left a comment
JosephMarinier
left a comment
Collaborator
There was a problem hiding this comment.
Great! Thank you! 👍
Co-authored-by: Joseph Marinier <Joseph.Marinier@gmail.com>
JosephMarinier
approved these changes
Jul 28, 2026
JosephMarinier
left a comment
JosephMarinier
left a comment
Collaborator
There was a problem hiding this comment.
Perfect! Thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.