Fix: MoE Memory Budgeting and Dynamic Multimodal Tokens#98
Open
roydsouza wants to merge 2 commits intoSharpAI:mainfrom
Open
Fix: MoE Memory Budgeting and Dynamic Multimodal Tokens#98roydsouza wants to merge 2 commits intoSharpAI:mainfrom
roydsouza wants to merge 2 commits intoSharpAI:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses two critical issues identified during an adversarial audit of SwiftLM on Apple Silicon (M5):
boaToken(255010) andeoaToken(255011) by extracting them dynamically fromconfig.json. This fixes expert routing for non-Qwen multimodal models.Changes
moeBuffertocomputeSSDMemoryBudget.sysctl vm.swapusagecheck inServer.swift.extractMultimodalTokensinOmniModelFactoryto resolve BOA/EOA tokens from config.Verified on Apple Silicon M5 with Gemma 4 MoE.