refactor(Calorimeter): obtain tomlplusplus via find_package#23
Conversation
Replace the FetchContent_Declare(tomlplusplus) block with a single find_package(tomlplusplus REQUIRED). This avoids fetching toml++ from GitHub at configure time and aligns with how the repo treats its other production dependencies (GeoModelCore, GeoModelIO, GeoModelTools). tomlplusplus is available on conda-forge and in most distros, so this is a small environment-setup requirement bump rather than a real friction increase. Builds without the package installed will fail at configure time with a clear CMake error pointing at the missing package.
|
Warning Review limit reached
More reviews will be available in 8 minutes and 37 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
Motivation
Surfaced while writing a `shipgeometry` recipe for `ship-conda-recipes`. `FetchContent` requires network at configure time, which we'd rather avoid in packaged builds. `tomlplusplus` is available on conda-forge (and as e.g. `libtomlplusplus-dev` on Debian/Ubuntu), so requiring it as a system dep is a small environment-setup bump rather than real friction.
Behaviour change
Builds without `tomlplusplus` installed will now fail at configure time with a clear CMake error pointing at the missing package, rather than silently downloading from GitHub. For contributors, `pixi install` / `apt install libtomlplusplus-dev` / `brew install tomlplusplus` covers it.
Test plan