fix: install apps/ executables#25
Conversation
build_geometry and validate_geometry are first-class CLI tools but
were never installed — apps/CMakeLists.txt defined them but had no
install rule. Packaged builds (conda recipe, distros) silently lost
both tools.
Add install(TARGETS build_geometry validate_geometry RUNTIME
DESTINATION ${CMAKE_INSTALL_BINDIR}). Pull GNUInstallDirs in locally
in apps/ — the top-level file's include comes too late to be visible
here.
|
Warning Review limit reached
More reviews will be available in 41 minutes and 19 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
Motivation
`build_geometry` and `validate_geometry` are the project's primary CLI tools but were never installed: `apps/CMakeLists.txt` defined them and stopped there, and the top-level `install(TARGETS ...)` block covers only the library targets. Packaged builds (e.g. our conda recipe) silently lost both binaries, and downstream users had no way to invoke them except by reaching into the build tree.
Test plan