Skip to content

fix: install apps/ executables#25

Open
olantwin wants to merge 1 commit into
mainfrom
fix/install-apps-executables
Open

fix: install apps/ executables#25
olantwin wants to merge 1 commit into
mainfrom
fix/install-apps-executables

Conversation

@olantwin
Copy link
Copy Markdown
Contributor

@olantwin olantwin commented Jun 4, 2026

Summary

  • Add an `install(TARGETS ...)` rule for `build_geometry` and `validate_geometry` in `apps/CMakeLists.txt` so the executables actually land in the install tree.
  • Pull `GNUInstallDirs` in locally — the top-level file's `include(GNUInstallDirs)` happens later, after `add_subdirectory(apps)` returns.

Motivation

`build_geometry` and `validate_geometry` are the project's primary CLI tools but were never installed: `apps/CMakeLists.txt` defined them and stopped there, and the top-level `install(TARGETS ...)` block covers only the library targets. Packaged builds (e.g. our conda recipe) silently lost both binaries, and downstream users had no way to invoke them except by reaching into the build tree.

Test plan

  • CI (`build-test.yml`) stays green — the change is purely additive.
  • Manual: `cmake -S . -B /tmp/g && cmake --build /tmp/g && cmake --install /tmp/g --prefix /tmp/g-install` produces `/tmp/g-install/bin/build_geometry` and `/tmp/g-install/bin/validate_geometry`.

build_geometry and validate_geometry are first-class CLI tools but
were never installed — apps/CMakeLists.txt defined them but had no
install rule. Packaged builds (conda recipe, distros) silently lost
both tools.

Add install(TARGETS build_geometry validate_geometry RUNTIME
DESTINATION ${CMAKE_INSTALL_BINDIR}). Pull GNUInstallDirs in locally
in apps/ — the top-level file's include comes too late to be visible
here.
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jun 4, 2026

Warning

Review limit reached

@olantwin, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 41 minutes and 19 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: eb798ecf-cf59-41f3-a34d-b134350bfb44

📥 Commits

Reviewing files that changed from the base of the PR and between a5bac91 and 4a6f24b.

📒 Files selected for processing (1)
  • apps/CMakeLists.txt
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/install-apps-executables

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant