chore(build): drop pre-project GNUInstallDirs include and add SQLite3::SQLite3 shim#28
Conversation
|
Warning Review limit reached
More reviews will be available in 11 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
c60d341 to
716bad4
Compare
…::SQLite3 shim Two unrelated but trivial CMake dev warnings surfaced on every CI configure step: - The top-level CMakeLists.txt included GNUInstallDirs before project(), which trips a 'no target architecture is known' warning because GNUInstallDirs cannot pick a libdir until a language is enabled. The second include later in the file (after project(... LANGUAGES CXX)) is correctly placed and already provides the install-dir variables used downstream — the pre-project include was redundant. - apps/CMakeLists.txt linked against SQLite::SQLite3. CMake 4.3 renamed the FindSQLite3 target to SQLite3::SQLite3 and marked the old name deprecated, so every target_link_libraries call against it fired a dev warning. Switch the linkage to SQLite3::SQLite3 and add the alias-shim recommended by the FindSQLite3 docs so the build still works on older CMake (< 4.3) that only ships SQLite::SQLite3. No behaviour change.
716bad4 to
92dcf84
Compare
Summary
Two unrelated but trivial CMake dev warnings that surfaced on every CI configure step. No behaviour change.
CMakeLists.txt:5—include(GNUInstallDirs)ran beforeproject(...), which trips a 'no target architecture is known' warning (GNUInstallDirs cannot pick a libdir until a language is enabled). The second include later in the file (afterproject(... LANGUAGES CXX)) is correctly placed and already provides the install-dir variables used downstream — the pre-project include was redundant.apps/CMakeLists.txt:15— CMake 4.3 renamed theFindSQLite3target toSQLite3::SQLite3and marked the old nameSQLite::SQLite3deprecated, so everytarget_link_librariesresolution against it fired a dev warning. Switch the linkage toSQLite3::SQLite3and add the alias-shim recommended by the FindSQLite3 docs so the build still works on older CMake (< 4.3) that only shipsSQLite::SQLite3.Test plan
CMake Warning (dev)lines from these two filesSQLite::SQLite3only) — the shim providesSQLite3::SQLite3as an alias, so the link succeeds