Pin SwiftLint & SwiftFormat via Mintfile#470
Draft
kieran-osgood-shopify wants to merge 1 commit intomainfrom
Draft
Pin SwiftLint & SwiftFormat via Mintfile#470kieran-osgood-shopify wants to merge 1 commit intomainfrom
kieran-osgood-shopify wants to merge 1 commit intomainfrom
Conversation
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Coverage Report
|
kieran-osgood-shopify
force-pushed
the
river/add-mintfile-for-swift-linters
branch
from
94eb1c1 to
94b0aee
Compare
kieran-osgood-shopify
force-pushed
the
river/migrate-yarn-to-pnpm
branch
from
675ccbe to
4dc92ca
Compare
kieran-osgood-shopify
force-pushed
the
river/add-mintfile-for-swift-linters
branch
from
94b0aee to
8af8997
Compare
kieran-osgood-shopify
force-pushed
the
river/migrate-yarn-to-pnpm
branch
from
4dc92ca to
81ff3f7
Compare
This was referenced Apr 27, 2026
kieran-osgood-shopify
force-pushed
the
river/migrate-yarn-to-pnpm
branch
from
81ff3f7 to
46c8b4f
Compare
kieran-osgood-shopify
force-pushed
the
river/add-mintfile-for-swift-linters
branch
2 times, most recently
from
ee6c1ad to
b1d76a6
Compare
kieran-osgood-shopify
force-pushed
the
river/migrate-yarn-to-pnpm
branch
from
46c8b4f to
05a1ef1
Compare
kieran-osgood-shopify
force-pushed
the
river/add-mintfile-for-swift-linters
branch
from
b1d76a6 to
ba955c1
Compare
kieran-osgood-shopify
force-pushed
the
river/migrate-yarn-to-pnpm
branch
from
05a1ef1 to
afe41c0
Compare
kieran-osgood-shopify
force-pushed
the
river/add-mintfile-for-swift-linters
branch
from
ba955c1 to
4c62949
Compare
kieran-osgood-shopify
force-pushed
the
river/migrate-yarn-to-pnpm
branch
from
afe41c0 to
64008fd
Compare
kieran-osgood-shopify
changed the base branch from
river/migrate-yarn-to-pnpm
to
graphite-base/470
kieran-osgood-shopify
force-pushed
the
graphite-base/470
branch
from
64008fd to
83edbc5
Compare
kieran-osgood-shopify
force-pushed
the
river/add-mintfile-for-swift-linters
branch
from
4c62949 to
494c2ef
Compare
Mirrors the setup in checkout-sheet-kit-swift: the `Mintfile` pins exact SwiftLint / SwiftFormat versions so local dev and CI always run the same linter binaries (no more "works on my machine" drift between whatever brew happens to install and whatever CI has cached). - Add `Mintfile` pinning `realm/SwiftLint@0.63.2` and `nicklockwood/SwiftFormat@0.61.0` (same pins as checkout-sheet-kit-swift for consistency across the two kits). - dev.yml: replace the bare `swiftlint` package with `mint` and `xcbeautify`, and add a `mint bootstrap` step so running `dev up` installs (or updates) the pinned toolchain into `.mint/`. This also fixes the "WARN: SwiftFormat not installed" warning developers were hitting — swiftformat wasn't being provisioned at all. - scripts/lint_swift: invoke `mint run swiftlint` / `mint run swiftformat` instead of relying on whatever binary is on PATH. Adds the `--verbose` flag that the update-linters workflow uses and keeps the same check/fix modes the existing script had. - .gitignore: ignore `.mint/` (Mint's local-install cache). - CONTRIBUTING.md: document the Mint-based flow and point at the update-linters workflow. Workflow changes (`.github/workflows/ci.yml` lint job + `.github/workflows/update-linters.yml`) are included as a patch in the PR description because the GitHub App pushing this branch doesn't have the `workflows` permission on this repo. Requested by Kieran Osgood <kieran.osgood@shopify.com>
kieran-osgood-shopify
force-pushed
the
river/add-mintfile-for-swift-linters
branch
from
494c2ef to
df4801e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you making?
PR Checklist
Important
Releasing a new version of the kit?
package.jsonfile.Tip
See the Contributing documentation for instructions on how to publish a new version of the library.