Replace build(options, lifecycle) with separate build() and bundle() methods

The lifecycle parameter was a flag argument signaling "this method does two
things." Splitting into two named methods makes each one do one thing, and
the composition (build then bundle) becomes plain code at the one call site
that needs it: buildForBundle.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Author: isaacroldan

packages/app/src/cli/models/extensions/extension-instance.test.ts

@@ -164,15 +164,15 @@ describe('build', async () => {
       const outputFilePath = joinPath(tmpDir, `dist/${extensionInstance.outputFileName}`)
 
       // When
-      await extensionInstance.build(options, 'build')
+      await extensionInstance.build(options)
 
       // Then
       const outputFileContent = await readFile(outputFilePath)
       expect(outputFileContent).toEqual('(()=>{})();')
     })
   })
 
-  test("'bundle' lifecycle still runs the build steps even when no 'bundle' group is declared", async () => {
+  test('bundle() is a no-op when the spec declares no bundle lifecycle group', async () => {
     await inTemporaryDirectory(async (tmpDir) => {
       // Given — tax_calculation only declares a 'build' lifecycle group.
       const extensionInstance = await testTaxCalculationExtension(tmpDir)
@@ -185,12 +185,11 @@ describe('build', async () => {
 
       const outputFilePath = joinPath(tmpDir, `dist/${extensionInstance.outputFileName}`)
 
-      // When — request the 'bundle' lifecycle. Composition still runs build steps even without a bundle group.
-      await extensionInstance.build(options, 'bundle')
+      // When — bundle() runs only the bundle steps; with none declared this is a no-op.
+      await extensionInstance.bundle(options)
 
-      // Then
-      const outputFileContent = await readFile(outputFilePath)
-      expect(outputFileContent).toEqual('(()=>{})();')
+      // Then — no output file is produced (build() was not called).
+      await expect(readFile(outputFilePath)).rejects.toThrow()
     })
   })
 

packages/app/src/cli/models/extensions/extension-instance.ts

@@ -317,36 +317,40 @@ export class ExtensionInstance<TConfiguration extends BaseConfigType = BaseConfi
     return Boolean(this.entrySourceFilePath.endsWith('.js') || this.entrySourceFilePath.endsWith('.ts'))
   }
 
-  async build(options: ExtensionBuildOptions, lifecycle: LifecyclePhase): Promise<void> {
-    const {clientSteps = []} = this.specification
+  async build(options: ExtensionBuildOptions): Promise<void> {
+    await this.runLifecyclePhase('build', options)
+  }
+
+  async bundle(options: ExtensionBuildOptions): Promise<void> {
+    await this.runLifecyclePhase('bundle', options)
+  }
+
+  async buildForBundle(options: ExtensionBuildOptions, bundleDirectory: string, outputId?: string) {
+    this.outputPath = this.getOutputPathForDirectory(bundleDirectory, outputId)
+    await this.build(options)
+    await this.bundle(options)
+
+    const bundleInputPath = joinPath(bundleDirectory, this.getOutputFolderId(outputId))
+    await this.keepBuiltSourcemapsLocally(bundleInputPath)
+  }
+
+  private async runLifecyclePhase(phase: LifecyclePhase, options: ExtensionBuildOptions): Promise<void> {
+    const steps = this.specification.clientSteps?.find((group) => group.lifecycle === phase)?.steps ?? []
+    if (steps.length === 0) return
 
     const context: BuildContext = {
       extension: this,
       options,
       stepResults: new Map(),
     }
 
-    // Phases compose additively: 'bundle' runs build steps first, then bundle steps.
-    // Steps within each group preserve declaration order.
-    const buildSteps = clientSteps.find((group) => group.lifecycle === 'build')?.steps ?? []
-    const bundleSteps = clientSteps.find((group) => group.lifecycle === 'bundle')?.steps ?? []
-    const steps = lifecycle === 'build' ? buildSteps : [...buildSteps, ...bundleSteps]
-
     for (const step of steps) {
       // eslint-disable-next-line no-await-in-loop
       const result = await executeStep(step, context)
       context.stepResults.set(step.id, result)
     }
   }
 
-  async buildForBundle(options: ExtensionBuildOptions, bundleDirectory: string, outputId?: string) {
-    this.outputPath = this.getOutputPathForDirectory(bundleDirectory, outputId)
-    await this.build(options, 'bundle')
-
-    const bundleInputPath = joinPath(bundleDirectory, this.getOutputFolderId(outputId))
-    await this.keepBuiltSourcemapsLocally(bundleInputPath)
-  }
-
   async copyIntoBundle(options: ExtensionBuildOptions, bundleDirectory: string, extensionUuid?: string) {
     const defaultOutputPath = this.outputPath
 

packages/app/src/cli/services/build.ts

@@ -42,7 +42,7 @@ async function build(options: BuildOptions) {
         return {
           prefix: ext.localIdentifier,
           action: async (stdout: Writable, stderr: Writable, signal: AbortSignal) => {
-            await ext.build({stdout, stderr, signal, app: options.app, environment: 'production'}, 'build')
+            await ext.build({stdout, stderr, signal, app: options.app, environment: 'production'})
           },
         }
       }),