Skip to content

[Refactor] Simplify copyDirectoryContents implementation #7433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gonzaloriestra wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[Refactor] Simplify copyDirectoryContents implementation #7433

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 1 addition & 17 deletions packages/cli-kit/src/public/node/fs.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -717,21 +717,5 @@ export async function copyDirectoryContents(srcDir: string, destDir: string): Pr
throw new Error(`Source directory ${srcDir} does not exist`)
}

if (!(await fileExists(destDir))) {
await mkdir(destDir)
}

// Get all files and directories in the source directory
const items = await glob(joinPath(srcDir, '**/*'))

const filesToCopy = []

for (const item of items) {
const relativePath = item.replace(srcDir, '').replace(/^[/\\]/, '')
const destPath = joinPath(destDir, relativePath)

filesToCopy.push(copyFile(item, destPath))
}

await Promise.all(filesToCopy)
await fsCopy(srcDir, destDir)
}
Loading