Fix modern Bun lockfile cleanup in app templates#7436
Open
afurm wants to merge 2 commits intoShopify:mainfrom
Open
Fix modern Bun lockfile cleanup in app templates#7436afurm wants to merge 2 commits intoShopify:mainfrom
afurm wants to merge 2 commits intoShopify:mainfrom
Conversation
Contributor
gonzaloriestra
left a comment
gonzaloriestra
left a comment
There was a problem hiding this comment.
Thanks a lot for your contribution!
The change makes sense, I just added a suggestion to simplify.
4 tasks
gonzaloriestra
approved these changes
May 5, 2026
Contributor
gonzaloriestra
left a comment
gonzaloriestra
left a comment
There was a problem hiding this comment.
Could you please rebase your PR? The CI should pass after that. Thanks!
afurm
force-pushed
the
af/fix-bun-lockfile-cleanup
branch
from
ef8cf8b to
face0ae
Compare
Author
Done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
No linked issue.
Shopify CLI already detects Bun projects from both
bun.lockband modernbun.lock, but app template cleanup only treatedbun.lockbas Bun's lockfile. This could leave stalebun.lockfiles or.gitignoreentries behind when initializing non-Bun app projects.WHAT is this pull request doing?
bun.lockto the shared lockfile list.lockfilesForPackageManager()so Bun keeps both valid Bun lockfile names.How to test your changes?
pnpm test packages/app/src/cli/services/init/template/cleanup.test.ts packages/cli-kit/src/public/node/node-package-manager.test.ts pnpm --filter @shopify/cli-kit type-check pnpm --filter @shopify/app type-check pnpm --filter @shopify/cli-kit lint pnpm --filter @shopify/app lintChecklist
patchfor bug fixes ·minorfor new features ·majorfor breaking changes) and added a changeset withpnpm changeset add