[Performance] Optimize Liquid template rendering#7475
[Performance] Optimize Liquid template rendering#7475gonzaloriestra wants to merge 1 commit intomainfrom
Conversation
- Reuse Liquid engine instance via shared singleton - Add fast-path for static strings without Liquid tags - Static strings are ~480x faster, templates ~3x faster
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
WHY are these changes introduced?
The
renderLiquidTemplatefunction in@shopify/cli-kitwas creating a newLiquidinstance on every invocation, which is expensive due to engine initialization. It also parsed and rendered every string regardless of whether it contained actual Liquid templates.WHAT is this pull request doing?
Liquidengine instance.includesto skip parsing/rendering for strings without{{or{%.Performance Impact (1000 iterations):
How to test your changes?
Verify that Liquid rendering still works correctly by running the unit tests:
pnpm --filter @shopify/cli-kit vitest run src/public/node/liquid.test.tsDuplicate check
Query ran:
git log --all --oneline --grep="[Performance]"Closest prior PRs considered:
694fcd735 [Performance] Optimize directory globbing with cwd: Optimizedglobusage inrecursiveLiquidTemplateCopybut did not touch the corerenderLiquidTemplateengine logic.357eaf03a [Performance] Optimize copyDirectoryContents: Focused on filesystem performance rather than template rendering.Checklist
patch) and added a changeset.PR created automatically by Jules for task 9657811168130259180 started by @gonzaloriestra