Switch deploy to the active-app-version classification#8056
Conversation
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
adc37e4 to
838bb7e
Compare
d8abcc9 to
6819f61
Compare
838bb7e to
146fd63
Compare
6819f61 to
7a73d6c
Compare
146fd63 to
9ce00c5
Compare
7a73d6c to
346a29f
Compare
9ce00c5 to
aefc40d
Compare
346a29f to
3036c8c
Compare
aefc40d to
03fa20e
Compare
644c235 to
3260c7b
Compare
2a3ef5e to
9cee8ca
Compare
c283e20 to
8876f69
Compare
9cee8ca to
8580282
Compare
8580282 to
8161f82
Compare
8876f69 to
8c9c96f
Compare
8c9c96f to
6f5abbc
Compare
8161f82 to
50f3d2c
Compare
6f5abbc to
c583dc4
Compare
dddc498 to
a63ce6f
Compare
c583dc4 to
2991088
Compare
Differences in type declarationsWe detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:
New type declarationsWe found no new type declarations in this PR Existing type declarationspackages/cli-kit/dist/public/common/version.d.ts@@ -1 +1 @@
-export declare const CLI_KIT_VERSION = "4.5.0";
\ No newline at end of file
+export declare const CLI_KIT_VERSION = "4.4.0";
\ No newline at end of file
|
Wires `deploy` to the new module: `ensureDeployContext` calls `ensureDeployIdentifiersFromAppVersion` and returns `DeployIdentifiers`, the bundle/upload path consumes the resulting maps (upload's `extensionIds` becomes `appModuleRegistrationIds`), and `deploy` no longer writes identifiers back to the .env file. The interactive matching flow is now unused; it is removed in the next commit. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2991088 to
9ea4edb
Compare
a63ce6f to
dc6cfea
Compare
Agree! The changeset is missing |
|
Actually, this wasn't happening anymore! only the Partners client forced this, and it is unused now. So this PR doesn't really modify that |
|
|

WHY are these changes introduced?
With the classification module in place (#8055),
deploycan stop using the interactive matching flow.WHAT is this pull request doing?
ensureDeployContextnow callsensureDeployIdentifiersFromAppVersionand returnsDeployIdentifiers.extensionIdsbecomesappModuleRegistrationIds.deployno longer writes identifiers back to the.envfile.The interactive matching flow is now unused; it's removed in #8049.
.env) — needs a changeset.How to test your changes?
pnpm --filter @shopify/app exec vitest run src/cli/services/deploy.test.ts src/cli/services/context.test.ts src/cli/services/deploy/upload.test.ts