Skip to content

Tighten store list BP test types#8082

Open
alfonso-noriega wants to merge 1 commit into
mainfrom
maintenance/store-list-bp-test-types
Open

Tighten store list BP test types#8082
alfonso-noriega wants to merge 1 commit into
mainfrom
maintenance/store-list-bp-test-types

Conversation

@alfonso-noriega

Copy link
Copy Markdown
Contributor

WHY are these changes introduced?

The Business Platform store-list tests used broad as any casts for mocked GraphQL responses and captured request options. That made the tests less useful as coverage for the generated query shape.

WHAT is this pull request doing?

  • Adds typed test helpers based on ListAccessibleShopsQuery.
  • Replaces inline untyped response objects with those helpers.
  • Replaces request-option as any casts with a small captured-request helper.

How to test your changes?

  • pnpm --filter @shopify/store vitest src/cli/services/store/list/bp-source.test.ts
  • pnpm --filter @shopify/store type-check
  • pnpm --filter @shopify/store lint
  • git diff --check

Post-release steps

None.

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've considered analytics changes to measure impact
  • The change is user-facing — I've identified the correct bump type (patch for bug fixes · minor for new features · major for breaking changes) and added a changeset with pnpm changeset add

Assisted-By: devx/31f235de-96f8-4f7a-9913-7f5ebb3a6b3b
@alfonso-noriega alfonso-noriega requested a review from a team as a code owner July 14, 2026 09:44
@github-actions github-actions Bot added the no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users. label Jul 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant