Tighten store list BP test types#8082
Open
alfonso-noriega wants to merge 1 commit into
Open
Conversation
Assisted-By: devx/31f235de-96f8-4f7a-9913-7f5ebb3a6b3b
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
The Business Platform store-list tests used broad
as anycasts for mocked GraphQL responses and captured request options. That made the tests less useful as coverage for the generated query shape.WHAT is this pull request doing?
ListAccessibleShopsQuery.as anycasts with a small captured-request helper.How to test your changes?
pnpm --filter @shopify/store vitest src/cli/services/store/list/bp-source.test.ts✅pnpm --filter @shopify/store type-check✅pnpm --filter @shopify/store lint✅git diff --check✅Post-release steps
None.
Checklist
patchfor bug fixes ·minorfor new features ·majorfor breaking changes) and added a changeset withpnpm changeset add