[Refactor] Modernize addResolutionOrOverride in node-package-manager.ts#8088
[Refactor] Modernize addResolutionOrOverride in node-package-manager.ts#8088gonzaloriestra wants to merge 1 commit into
Conversation
Refactor `addResolutionOrOverride` to use a more declarative approach with property key lookup and leverage the `writePackageJSON` helper. This reduces duplication and improves maintainability.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
WHY are these changes introduced?
Improve code readability and maintainability by using a more declarative approach and leveraging existing helpers.
WHAT is this pull request doing?
Refactors
addResolutionOrOverrideinpackages/cli-kit/src/public/node/node-package-manager.tsto:ifblocks for package manager checks with a declarative property lookup forresolutionsoroverrides.writePackageJSONhelper instead of manualwriteFileandJSON.stringifycalls.How to test your changes?
CI
Checklist
patchfor bug fixes ·minorfor new features ·majorfor breaking changes) and added a changeset withpnpm changeset addPR created automatically by Jules for task 14636034994671192679 started by @gonzaloriestra