Skip to content

Make analytics storage timing test deterministic #8091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
alfonso-noriega wants to merge 1 commit into
base: main
Choose a base branch
from
+13 −7
Draft

Make analytics storage timing test deterministic #8091

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 13 additions & 7 deletions packages/cli-kit/src/private/node/analytics/storage.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import {recordTiming, recordError, recordRetry, recordEvent, compileData, reset} from './storage.js'
import {ErrorCategory} from './error-categorizer.js'
import {describe, test, expect, beforeEach} from 'vitest'
import {describe, test, expect, beforeEach, vi} from 'vitest'

describe('analytics/storage', () => {
beforeEach(() => {
Expand All @@ -21,12 +21,16 @@ describe('analytics/storage', () => {

test('completes a timing when called second time', () => {
// Given
recordTiming('test-event')
vi.useFakeTimers()
const startTime = new Date('2026-01-01T00:00:00.000Z')
const delay = 10
const delayPromise = new Promise((resolve) => setTimeout(resolve, delay))

// When
return delayPromise.then(() => {
try {
vi.setSystemTime(startTime)
recordTiming('test-event')

// When
vi.setSystemTime(new Date(startTime.getTime() + delay))
recordTiming('test-event')

// Then
Expand All @@ -35,12 +39,14 @@ describe('analytics/storage', () => {

const timing = data.timings[0]
expect(timing?.event).toBe('test-event')
expect(timing?.duration).toBeGreaterThanOrEqual(0)
expect(timing?.duration).toBe(delay)

expect(data.events.length).toBe(2)
expect(data.events[0]?.name).toBe('timing:start:test-event')
expect(data.events[1]?.name).toBe('timing:end:test-event')
})
} finally {
vi.useRealTimers()
}
})

test('handles multiple concurrent timings', () => {
Expand Down
Loading