Fix warning when running theme commands in valid theme directories#8092
Open
karreiro wants to merge 1 commit into
Open
Fix warning when running theme commands in valid theme directories#8092karreiro wants to merge 1 commit into
karreiro wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts the heuristic used by the theme CLI to decide whether a working directory “looks like” a theme directory, to avoid showing a warning when running theme commands in certain valid theme setups.
Changes:
- Loosen
hasRequiredThemeDirectoriesby removingsectionsfrom the required directory list. - Add a unit test covering the relaxed “minimum required directories” behavior.
- Add a patch changeset for
@shopify/theme.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/theme/src/cli/utilities/theme-fs.ts | Updates the directory heuristic for detecting theme directories. |
| packages/theme/src/cli/utilities/theme-fs.test.ts | Adds test coverage for the updated heuristic. |
| .changeset/fix-theme-directory-warning.md | Adds a patch changeset documenting the user-facing warning fix. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
isaacroldan
reviewed
Jul 15, 2026
| '@shopify/theme': patch | ||
| --- | ||
|
|
||
| Fix warning when running theme commands in valid theme directories |
Contributor
There was a problem hiding this comment.
No need for changeset here, since it is already included in the other branch, we don't want to show it again in the next minor.
isaacroldan
approved these changes
Jul 15, 2026
graygilmore
approved these changes
Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Fix warning when running theme commands in valid theme directories.
WHAT is this pull request doing?
Updating the list of required directories.
Post-release steps
N/A
Checklist
patchfor bug fixes ·minorfor new features ·majorfor breaking changes) and added a changeset withpnpm changeset add