Open
Conversation
Morriar
force-pushed
the
at/rbs-comment-signatures
branch
from
fa09654 to
52480ca
Compare
| thor (>= 1.2.0) | ||
| tsort | ||
| thor (1.5.0) | ||
| thor (1.4.0) |
Contributor
Author
There was a problem hiding this comment.
Good catch, not sure why bundler decided to downgrade some gems because I remove sorbet-runtime
Contributor
There was a problem hiding this comment.
Downgrades are still there
* Use conservative rubocop bump (1.69.0 instead of 1.86.1) to minimize transitive dependency changes * Add minitest-mock gem (extracted from minitest 6) to restore Object#stub * Require "parser" instead of sub-files to fix AST constant load order with parser 3.3.11.1 * Use Prism::Translation::Parser::Builder as base class for TolerateInvalidUtf8Builder to fix Prism 1.9.0 deprecation warnings * Update integration test to match new nil error message after T.must removal
Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
Morriar
force-pushed
the
at/rbs-comment-signatures
branch
from
52480ca to
fdeee74
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrate all Sorbet
sigblocks and type annotations to RBS comment signatures, allowing us to drop the runtime dependency onsorbet-runtime.The main goal is to remove the
sorbet-runtimedependency from the gem. This eliminates the runtime overhead of signature validation and method wrapping, boosting performance for all Packwerk users — especially on large codebases where the cost ofsorbet-runtimeadds up across thousands of file checks.What changed
sigblocks to#:RBS comment signaturesT.let,T.cast,T.must,T.bind,T.unsafeto RBS comment equivalents (#: as Type,#: as !nil, etc.)T.type_aliasto#: type name = ...RBS syntaxT::Structsubclasses to plain Ruby classesextend T::Sig,extend T::Helpers,T::Genericsusagesorbet-runtimefrom gemspec dependenciesdisable_sorbet.rbshim (no longer needed)