Add preferPrimaryDefinition setting for go to definition#4168
Closed
sucicfilip wants to merge 1 commit into
Closed
Add preferPrimaryDefinition setting for go to definition#4168sucicfilip wants to merge 1 commit into
sucicfilip wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
In apps that reopen classes across many files (packwerk monoliths, engines, etc.), go to definition on a constant always opens a picker listing every reopening. Most of the time I just want the file that actually defines the class.
Implementation
Adds an opt-in
featuresConfiguration.definition.preferPrimaryDefinitionsetting. When a constant resolves to multiple namespace entries, only the entries whose file path matches the fully qualified constant name following the Zeitwerk convention are returned (Core::Flags→core/flags.rb). If no entry matches, the behavior is unchanged. Methods and plain constants are not affected.Automated Tests
Two new tests: jumping to the convention-matching file, and the fallback when no file matches.