Make aasm compiler v6.0 aware#2672
Open
allan-thatch wants to merge 1 commit into
Open
Conversation
Author
|
I have signed the CLA! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes #2671. Also see "Migrating from AASM version 5 to 6".
Implementation
The aasm compiler now (a) withholds plain methods when namespaced and on v6 and (b) adds the namespaced
_without_validation!method when on v6.Tests
I updated the compiler test to accommodate the v6.0 path, but didn't add a backtest for v5.5.2 and lower. Let me know if you'd like to see that; otherwise, I ran a local test by pinning the older version and restoring the original RBI fixture: