Remove dependency on sparse-checkout-roots#29
Open
joshheinrichs-shopify wants to merge 1 commit intotecnix-gcsfrom
Open
Remove dependency on sparse-checkout-roots#29joshheinrichs-shopify wants to merge 1 commit intotecnix-gcsfrom
joshheinrichs-shopify wants to merge 1 commit intotecnix-gcsfrom
Conversation
If sparse-checkout-roots is out of sync with the files in the sparse checkout, dirty files will be ignored which is very confusing and difficult to diagnose. At this point we can work off the whole sparse checkout efficiently so there's no need to explicitly flip between git / source-available modes on a per-zone basis.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If sparse-checkout-roots is out of sync with the files in the sparse checkout, dirty files will be ignored which is very confusing and difficult to diagnose. At this point we can work off the whole sparse checkout efficiently so there's no need to explicitly flip between git / source-available modes on a per-zone basis.