Handle character width and offscreen rendering#51
Merged
Conversation
In the case when moving from right-to-left, printing whitespace to clear the trail was causing issues when clearing the last element which had already been cleared. The logic now checks if the x position is less than the width of the symbol to render and adjusts the clear logic accordingly
Doesn't need to be mutable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement logic to account for character widths in rendering and movement calculations.
Introduce a private width field for entities and optimize boundary checks for offscreen conditions.
Adjust random symbol generation to respect column widths and improve trail clearing logic for right-to-left movement.
Without the unicode-width changes, horizontal/diagonal movements had these issues: