Skip to content
This repository was archived by the owner on Feb 12, 2026. It is now read-only.

SIGN-7496 - enhance directory resolution logic in HelperArtifactDownload #38

Merged
Taha-cmd merged 3 commits into from
Apr 25, 2025
Merged

SIGN-7496 - enhance directory resolution logic in HelperArtifactDownload #38

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2ab03f1
SIGN-7496 - enhance directory resolution logic in HelperArtifactDownload
volodymyr-bobko Apr 11, 2025
892d8c6
SIGN-7496 Improve naming
Taha-cmd Apr 23, 2025
3c29ba2
SIGN-7469 Add unit test
Taha-cmd Apr 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions actions/submit-signing-request/helper-artifact-download.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,11 +68,14 @@ export class HelperArtifactDownload {
}

private resolveOrCreateDirectory(relativePath:string): string {
Copy link
Copy Markdown
Contributor

@Taha-cmd Taha-cmd Apr 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename parameter from relativePath to path, since it can be both absolute and relative now

const absolutePath = path.join(process.env.GITHUB_WORKSPACE as string, relativePath)
const workingDirectory = process.env.GITHUB_WORKSPACE as string;
const absolutePath = path.isAbsolute(relativePath) ? relativePath :
path.join(workingDirectory as string, relativePath);

if (!fs.existsSync(absolutePath)) {
core.info(`Directory "${absolutePath}" does not exist and will be created`);
fs.mkdirSync(absolutePath, { recursive: true });
}
return absolutePath;
}
}
}
Loading